Add watchlist support to git-cl.

git-cl

 #!/usr/bin/python
 # git-cl -- a git-command for integrating reviews on Rietveld
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 import getpass
 import optparse
 import os
 import re
 import readline
 import subprocess
@@ skipping 33 matching lines @@
     DieWithError('Command "%s" failed.\n' % (' '.join(cmd)) +
                  (error_message or output))
   return output
 
 
 def RunGit(args, **kwargs):
   cmd = ['git'] + args
   return RunCommand(cmd, **kwargs)
 
 
-class Settings:
+class Settings(object):
   def __init__(self):
     self.server = None
     self.cc = None
     self.root = None
     self.is_git_svn = None
     self.svn_branch = None
     self.tree_status_url = None
     self.viewvc_url = None
 
   def GetServer(self, error_ok=False):
     if not self.server:
       if not error_ok:
         error_message = ('You must configure your review setup by running '
                          '"git cl config".')
         self.server = self._GetConfig('rietveld.server',
                                       error_message=error_message)
       else:
         self.server = self._GetConfig('rietveld.server', error_ok=True)
     return self.server
 
   def GetCCList(self):
+    """Return the users cc'd on this CL.
+
+    Return is a string suitable for passing to gcl with the --cc flag.
+    """
     if self.cc is None:
       self.cc = self._GetConfig('rietveld.cc', error_ok=True)
+      more_cc = self._GetConfig('rietveld.extra_cc', error_ok=True)

[Mandeep Singh Baines, 2009/12/04 19:28:17]

What is the use case for rietveld.extra_cc? I'm guessing its to setup a CC_LIST
specific to the current issue which you want to persist for the duration of the
issue. In that case, you'd want to store extra_cc in the branch config. See
_IssueSetting() for an example.

Here, we are storing extra_cc as a repo config which persists across branches.
Not sure why someone would want to do that.

+      if more_cc is not None:
+        self.cc += ',' + more_cc
     return self.cc
 
   def GetRoot(self):
     if not self.root:
       self.root = os.path.abspath(RunGit(['rev-parse', '--show-cdup']).strip())
     return self.root
 
   def GetIsGitSvn(self):
     """Return true if this repo looks like it's using git-svn."""
     if self.is_git_svn is None:
@@ skipping 100 matching lines @@
 def IssueURL(issue):
   """Get the URL for a particular issue."""
   return 'http://%s/%s' % (settings.GetServer(), issue)
 
 
 def ShortBranchName(branch):
   """Convert a name like 'refs/heads/foo' to just 'foo'."""
   return branch.replace('refs/heads/', '')
 
 
-class Changelist:
+class Changelist(object):
   def __init__(self, branchref=None):
     # Poke settings so we get the "configure your server" message if necessary.
     settings.GetServer()
     self.branchref = branchref
     if self.branchref:
       self.branch = ShortBranchName(self.branchref)
     else:
       self.branch = None
     self.upstream_branch = None
     self.has_issue = False
@@ skipping 693 matching lines @@
   command = argv[1]
   for name, _, func in COMMANDS:
     if name == command:
       return func(argv[2:])
   print 'unknown command: %s' % command
   Usage(argv[0])
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))