Issue 46088: Revert 1469 and 1472 due to a bug with array literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46088: Revert 1469 and 1472 due to a bug with array literals. (Closed)

Created:
11 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
iposva, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert 1432, 1433, 1469 and 1472 due to a bug with literal objects. Committed: http://code.google.com/p/v8/source/detail?r=1511

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -416 lines)			Patch
M	src/ast.h	View	1	7 chunks	+15 lines, -34 lines	0 comments	Download
M	src/ast.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/codegen-arm.cc	View	1	5 chunks	+13 lines, -77 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1	3 chunks	+34 lines, -103 lines	0 comments	Download
M	src/heap.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/parser.h	View		2 chunks	+0 lines, -30 lines	0 comments	Download
M	src/parser.cc	View	1	5 chunks	+15 lines, -65 lines	0 comments	Download
M	src/runtime.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1	6 chunks	+26 lines, -98 lines	0 comments	Download
M	test/mjsunit/fuzz-natives.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	test/mjsunit/regress/regress-279.js	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 9 months ago (2009-03-15 14:26:59 UTC) #2

LGTM, thanks Erik!

http://codereview.chromium.org/46088/diff/1/2
File test/mjsunit/regress/regress-279.js (right):

http://codereview.chromium.org/46088/diff/1/2#newcode29
Line 29: return { foo: [] };
Please add a test case for a nested object literal that you modify: 

  { bar: {} };

as well as an object literal nested in an array literal:

  [ {} ];

Expand Messages | Collapse Messages