Issue 460105: Fix issue 23221: accesskey is not supported on Chromium Mac....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460105: Fix issue 23221: accesskey is not supported on Chromium Mac.... (Closed)

Created:
11 years ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Nico, Hironori Bono

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix issue 23221: accesskey is not supported on Chromium Mac. The key point is to provide correct unmodifiedText field for fabricated Char events, because in webkit, unmodifiedText is used for matching accesskey. BUG=23221 TEST=See bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34035

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View		3 chunks	+17 lines, -8 lines	0 comments	Download
	M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View		1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LG.

Expand Messages | Collapse Messages