Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/tab_contents/tab_contents_view_mac.mm

Issue 460105: Fix issue 23221: accesskey is not supported on Chromium Mac.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents_view_mac.mm
===================================================================
--- chrome/browser/tab_contents/tab_contents_view_mac.mm (revision 33947)
+++ chrome/browser/tab_contents/tab_contents_view_mac.mm (working copy)
@@ -356,18 +356,12 @@
}
- (BOOL)processKeyboardEvent:(NativeWebKeyboardEvent*)wkEvent {
- if (wkEvent->skip_in_browser)
+ if (wkEvent->skip_in_browser || wkEvent->type == WebKit::WebInputEvent::Char)
return NO;
NSEvent* event = wkEvent->os_event;
+ DCHECK(event != NULL);
- if (!event) {
- // Char events are synthesized and do not contain a real event. We are not
- // interested in them anyway.
- DCHECK(wkEvent->type == WebKit::WebInputEvent::Char);
- return NO;
- }
-
// If this tab is no longer active, its window will be |nil|. In that case,
// best ignore the event.
if (![self window])
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698