Cleanup converting safe-browsing chunks to range list.

Cleanup converting safe-browsing chunks to range list.

Rewrite multiple helper functions to just go directly from the vector
of chunks to the range string.

BUG=none
TEST=Unit tests green.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65271

[Scott Hess - ex-Googler, 2010-11-05 18:33:45]

This was leftover from an ancient refactoring, but in the end it hardly seemed
worthwhile.  I noticed that you were doing something like this in your CL, so I
figured I'd polish it off and let you review it.

[lzheng, 2010-11-05 21:43:28]

Very neat.

http://codereview.chromium.org/4588001/diff/1/4
File chrome/browser/safe_browsing/chunk_range_unittest.cc (right):

http://codereview.chromium.org/4588001/diff/1/4#newcode76
chrome/browser/safe_browsing/chunk_range_unittest.cc:76: EXPECT_EQ(range_string,
std::string("1-3,7"));
It might worth adding a test with unsorted inputs.

[lzheng, 2010-11-05 21:44:26]

http://codereview.chromium.org/4588001/diff/1/2
File chrome/browser/safe_browsing/chunk_range.cc (right):

http://codereview.chromium.org/4588001/diff/1/2#newcode36
chrome/browser/safe_browsing/chunk_range.cc:36: int range_end = *iter++;
Nit:
I wonder if you want to break this to two statements:
int range_end = *iter;
++iter;
So does the line 40. It is easier to read, but it's up to you.

[Scott Hess - ex-Googler, 2010-11-05 23:05:19]

thanks!

http://codereview.chromium.org/4588001/diff/1/2
File chrome/browser/safe_browsing/chunk_range.cc (right):

http://codereview.chromium.org/4588001/diff/1/2#newcode36
chrome/browser/safe_browsing/chunk_range.cc:36: int range_end = *iter++;
On 2010/11/05 21:44:28, lzheng wrote:
> Nit:
> I wonder if you want to break this to two statements:
> int range_end = *iter;
> ++iter;
> So does the line 40. It is easier to read, but it's up to you.

Done.

http://codereview.chromium.org/4588001/diff/1/4
File chrome/browser/safe_browsing/chunk_range_unittest.cc (right):

http://codereview.chromium.org/4588001/diff/1/4#newcode76
chrome/browser/safe_browsing/chunk_range_unittest.cc:76: EXPECT_EQ(range_string,
std::string("1-3,7"));
On 2010/11/05 21:43:28, lzheng wrote:
> It might worth adding a test with unsorted inputs.

Done.