Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3832)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.cc

Issue 4588001: Cleanup converting safe-browsing chunks to range list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Lei comments. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/chunk_range_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_database.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.cc b/chrome/browser/safe_browsing/safe_browsing_database.cc
index d5be4480e3dab29ac848527ab1da7e86cb454d11..e741c60b6188a37b98ee0830e4a24e3ac7847afd 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database.cc
@@ -123,15 +123,8 @@ void GetChunkIds(const std::vector<int>& chunks,
}
}
- std::sort(malware_chunks.begin(), malware_chunks.end());
- std::vector<ChunkRange> malware_ranges;
- ChunksToRanges(malware_chunks, &malware_ranges);
- RangesToString(malware_ranges, malware_list);
-
- std::sort(phishing_chunks.begin(), phishing_chunks.end());
- std::vector<ChunkRange> phishing_ranges;
- ChunksToRanges(phishing_chunks, &phishing_ranges);
- RangesToString(phishing_ranges, phishing_list);
+ ChunksToRangeString(malware_chunks, malware_list);
+ ChunksToRangeString(phishing_chunks, phishing_list);
}
// Order |SBAddFullHash| on the prefix part. |SBAddPrefixLess()| from
« no previous file with comments | « chrome/browser/safe_browsing/chunk_range_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698