Fix ThumbnailGenerator on Windows.

Fix ThumbnailGenerator on Windows.

In the browser, duplicate the file mapping handle before sending to the
renderer and map the TransportDIB before accessing the memory. In the
renderer, do not map the file twice, which was happening when
TransportDIB::Map and GetPlatformCanvas were both being called.
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65775

[kkania, 2010-11-05 18:11:07]

I have not yet finished investigating why the page cyclers were unhappy with my
second CL that you reviewed (http://codereview.chromium.org/3834003). In the
meantime, I would like to push through this change which fixes the
ThumbnailGenerator. The GPU and the WebDriver guys need this for their testing.

The first patch is an unrevert of my second CL you reviewed.

[kkania, 2010-11-09 01:59:46]

ping; if you are too busy, I can find another reviewer

[brettw, 2010-11-09 06:02:40]

Sorry I took so long, it takes a long time for me to page in the transport DIB
stuff into my head since it's quite complicated. I think I understand this
change and it looks good to me.

LGTM

http://codereview.chromium.org/4569002/diff/16001/17004
File app/surface/transport_dib_win.cc (right):

http://codereview.chromium.org/4569002/diff/16001/17004#newcode9
app/surface/transport_dib_win.cc:9: #include "app/surface/transport_dib.h"
Technically this include should be first. Can you move it up to the top while
you're reordering includes?

[kkania, 2012-05-10 19:54:12]

http://codereview.chromium.org/4569002/diff/16001/app/surface/transport_dib_w...
File app/surface/transport_dib_win.cc (right):

http://codereview.chromium.org/4569002/diff/16001/app/surface/transport_dib_w...
app/surface/transport_dib_win.cc:9: #include "app/surface/transport_dib.h"
On 2010/11/09 06:02:40, brettw wrote:
> Technically this include should be first. Can you move it up to the top while
> you're reordering includes?

Done.