Fix ThumbnailGenerator on Windows.

chrome/browser/tab_contents/thumbnail_generator.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/thumbnail_generator.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/metrics/histogram.h"
+#include "base/scoped_ptr.h"
 #include "base/time.h"
 #include "build/build_config.h"
 #include "chrome/browser/renderer_host/backing_store.h"
+#include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/property_bag.h"
 #include "gfx/rect.h"
 #include "gfx/skbitmap_operations.h"
 #include "skia/ext/platform_canvas.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
+#if defined(OS_WIN)
+#include "app/win_util.h"
+#endif
+
 // Overview
 // --------
 // This class provides current thumbnails for tabs. The simplest operation is
 // when a request for a thumbnail comes in, to grab the backing store and make
 // a smaller version of that.
 //
 // A complication happens because we don't always have nice backing stores for
 // all tabs (there is a cache of several tabs we'll keep backing stores for).
 // To get thumbnails for tabs with expired backing stores, we listen for
 // backing stores that are being thrown out, and generate thumbnails before
@@ skipping 152 matching lines @@
       return;
     }
     // Now, if the backing store didn't exist, we will still try and
     // render asynchronously.
   }
 
   // We are going to render the thumbnail asynchronously now, so keep
   // this callback for later lookup when the rendering is done.
   static int sequence_num = 0;
   sequence_num++;
-  TransportDIB* thumbnail_dib = TransportDIB::Create(
-      desired_size.width() * desired_size.height() * 4, sequence_num);
+  scoped_ptr<TransportDIB> thumbnail_dib(TransportDIB::Create(
+      desired_size.width() * desired_size.height() * 4, sequence_num));
+
+#if defined(OS_WIN)
+  // Duplicate the handle to the DIB here because the renderer process does not
+  // have permission. The duplicated handle is owned by the renderer process,
+  // which is responsible for closing it.
+  TransportDIB::Handle renderer_dib_handle = win_util::GetSectionForProcess(
+      thumbnail_dib->handle(),
+      renderer->process()->GetHandle(),
+      false);
+  if (!renderer_dib_handle) {
+    LOG(WARNING) << "Could not duplicate dib handle for renderer";
+    delete callback;
+    return;
+  }
+#else
+  TransportDIB::Handle renderer_dib_handle = thumbnail_dib->handle();
+#endif
 
   linked_ptr<AsyncRequestInfo> request_info(new AsyncRequestInfo);
   request_info->callback.reset(callback);
-  request_info->thumbnail_dib.reset(thumbnail_dib);
+  request_info->thumbnail_dib.reset(thumbnail_dib.release());
   request_info->renderer = renderer;
   ThumbnailCallbackMap::value_type new_value(sequence_num, request_info);
   std::pair<ThumbnailCallbackMap::iterator, bool> result =
       callback_map_.insert(new_value);
   if (!result.second) {
     NOTREACHED() << "Callback already registered?";
     return;
   }
 
   renderer->PaintAtSize(
-      thumbnail_dib->handle(), sequence_num, page_size, desired_size);
+      renderer_dib_handle, sequence_num, page_size, desired_size);
 }
 
 SkBitmap ThumbnailGenerator::GetThumbnailForRenderer(
     RenderWidgetHost* renderer) const {
   WidgetThumbnail* wt = GetDataForHost(renderer);
 
   BackingStore* backing_store = renderer->GetBackingStore(false);
   if (!backing_store) {
     // When we have no backing store, there's no choice in what to use. We
     // have to return either the existing thumbnail or the empty one if there
@@ skipping 70 matching lines @@
 
 void ThumbnailGenerator::WidgetDidReceivePaintAtSizeAck(
     RenderWidgetHost* widget,
     int sequence_num,
     const gfx::Size& size) {
   // Lookup the callback, run it, and erase it.
   ThumbnailCallbackMap::iterator item = callback_map_.find(sequence_num);
   if (item != callback_map_.end()) {
     TransportDIB* dib = item->second->thumbnail_dib.get();
     DCHECK(dib);
-    if (!dib) {
+    if (!dib || !dib->Map()) {
       return;
     }
 
     // Create an SkBitmap from the DIB.
     SkBitmap non_owned_bitmap;
     SkBitmap result;
 
     // Fill out the non_owned_bitmap with the right config.  Note that
     // this code assumes that the transport dib is a 32-bit ARGB
     // image.
@@ skipping 132 matching lines @@
                  &ThumbnailGenerator::ShownDelayHandler);
   }
 }
 
 void ThumbnailGenerator::EraseHostFromShownList(RenderWidgetHost* widget) {
   std::vector<RenderWidgetHost*>::iterator found =
       std::find(shown_hosts_.begin(), shown_hosts_.end(), widget);
   if (found != shown_hosts_.end())
     shown_hosts_.erase(found);
 }