Issue 4566001: Fix for bug 8764 that breaks prebuilts for files with more than just keyword pairs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4566001: Fix for bug 8764 that breaks prebuilts for files with more than just keyword pairs. (Closed)

Created:
10 years, 1 month ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
oshima

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Fix for bug 8764 that breaks prebuilts for files with more than just keyword pairs. I've also modified the unit test so it actually tests for this case. Change-Id: I6688d3be7bf1d8962031fcf1d684ddcaab43ba9f BUG=8764 TEST=Unittests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=170bde0

Patch Set 1 #

Patch Set 2 : Add unittest #

Patch Set 3 : Remove unnecessary check of = in string #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	prebuilt.py	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	prebuilt_unittest.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Thank you for prompt fix!

Expand Messages | Collapse Messages