prebuilt.py - Issue 4566001: Fix for bug 8764 that breaks prebuilts for files with more than just keyword pairs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: prebuilt.py

Issue 4566001: Fix for bug 8764 that breaks prebuilts for files with more than just keyword pairs. (Closed) Base URL: http://git.chromium.org/git/crosutils.git@master

Patch Set: Remove unnecessary check of = in string Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: prebuilt.py

diff --git a/prebuilt.py b/prebuilt.py

index df7f6e36dc5335dc845bbe669e1503a5ee309e44..a029159ed42d849dda1647a30d3873cf11d337b3 100755

--- a/prebuilt.py

+++ b/prebuilt.py

@@ -92,8 +92,8 @@ def UpdateLocalFile(filename, value, key='PORTAGE_BINHOST'):

# Strip newlines from end of line. We already add newlines below.

line = line.rstrip("\n")

- if '=' not in line:

- # Skip any line without an equal in it and just write it out.

+ if len(line.split('=')) != 2:

+ # Skip any line that doesn't fit key=val.

file_lines.append(line)

continue

« no previous file with comments | « no previous file | prebuilt_unittest.py » ('j') | no next file with comments »