Issue 456: Disable three debug tests that failed because they rely on wrong for-in order...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 456: Disable three debug tests that failed because they rely on wrong for-in order... (Closed)

Created:
12 years, 3 months ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Disable three debug tests that failed because they rely on wrong for-in order. Added a DISABLED_TEST macro to cctest.h, and cleanup cctest.cc a bit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -33 lines)			Patch
M	test/cctest/cctest.h	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	test/cctest/cctest.cc	View	5 chunks	+28 lines, -28 lines	1 comment	Download
M	test/cctest/test-debug.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 3 months ago (2008-09-05 00:00:04 UTC) #2

Except for the open question regarding C++ style LGTM.

-Ivan

http://codereview.chromium.org/456/diff/1/3
File test/cctest/cctest.cc (right):

http://codereview.chromium.org/456/diff/1/3#newcode39
Line 39: bool enabled) : callback_(callback), name_(name), prev_(last_) {
Not sure this is the proper style for wrapping parameters and initializer lists.
The style guide is somewhat ambiguous on this.

Expand Messages | Collapse Messages