Disable three debug tests that failed because they rely on wrong for-in order...

test/cctest/cctest.cc

 // Copyright 2008 Google Inc. All Rights Reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 17 matching lines @@
 #include <v8.h>
 #include <cstdlib>
 #include <cstring>
 #include <cstdio>
 #include "cctest.h"
 
 
 CcTest* CcTest::last_ = NULL;
 
 
-CcTest::CcTest(TestFunction* callback, const char* file, const char* name)
-    : callback_(callback), name_(name), prev_(last_) {
+CcTest::CcTest(TestFunction* callback, const char* file, const char* name,
+    bool enabled) : callback_(callback), name_(name), prev_(last_) {

[iposva, 2008/09/05 00:00:04]

Not sure this is the proper style for wrapping parameters and initializer lists.
The style guide is somewhat ambiguous on this.

   // Find the base name of this test (const_cast required on Windows).
   char *basename = strrchr(const_cast<char *>(file), '/');
   if (!basename) {
     basename = strrchr(const_cast<char *>(file), '\\');
   }
   if (!basename) {
     basename = strdup(file);
   } else {
     basename = strdup(basename + 1);
   }
   // Drop the extension, if there is one.
   char *extension = strrchr(basename, '.');
   if (extension) *extension = 0;
   // Install this test in the list of tests
   file_ = basename;
+  enabled_ = enabled;
   prev_ = last_;
   last_ = this;
 }
 
 
 static void PrintTestList(CcTest* current) {
   if (current == NULL) return;
   PrintTestList(current->prev());
   printf("%s/%s\n", current->file(), current->name());
 }
 
 
-static int RunMatchingTests(CcTest* current, char* file_or_name) {
-  if (current == NULL) return 0;
-  int run_count = 0;
-  if (strcmp(current->file(), file_or_name) == 0
-      || strcmp(current->name(), file_or_name) == 0) {
-    current->Run();
-    run_count++;
-  }
-  return run_count + RunMatchingTests(current->prev(), file_or_name);
-}
-
-
-static int RunMatchingTests(CcTest* current, char* file, char* name) {
-  if (current == NULL) return 0;
-  int run_count = 0;
-  if (strcmp(current->file(), file) == 0
-      && strcmp(current->name(), name) == 0) {
-    current->Run();
-    run_count++;
-  }
-  return run_count + RunMatchingTests(current->prev(), file, name);
-}
-
-
 int main(int argc, char* argv[]) {
   v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
   int tests_run = 0;
   bool print_run_count = true;
   for (int i = 1; i < argc; i++) {
     char* arg = argv[i];
     if (strcmp(arg, "--list") == 0) {
       PrintTestList(CcTest::last());
       print_run_count = false;
+
     } else {
       char* arg_copy = strdup(arg);
       char* testname = strchr(arg_copy, '/');
       if (testname) {
         // Split the string in two by nulling the slash and then run
         // exact matches.
         *testname = 0;
-        tests_run += RunMatchingTests(CcTest::last(), arg_copy, testname + 1);
+        char* file = arg_copy;
+        char* name = testname + 1;
+        CcTest* test = CcTest::last();
+        while (test != NULL) {
+          if (test->enabled()
+              && strcmp(test->file(), file) == 0
+              && strcmp(test->name(), name) == 0) {
+            test->Run();
+            tests_run++;
+          }
+          test = test->prev();
+        }
+
       } else {
         // Run all tests with the specified file or test name.
-        tests_run += RunMatchingTests(CcTest::last(), arg_copy);
+        char* file_or_name = arg_copy;
+        CcTest* test = CcTest::last();
+        while (test != NULL) {
+          if (test->enabled()
+              && (strcmp(test->file(), file_or_name) == 0
+                  || strcmp(test->name(), file_or_name) == 0)) {
+            test->Run();
+            tests_run++;
+          }
+          test = test->prev();
+        }
       }
       free(arg_copy);
     }
   }
   if (print_run_count && tests_run != 1)
     printf("Ran %i tests.\n", tests_run);
   return 0;
 }