Make no-tcmalloc (really, non-base/allocator) builds work again,...

Make no-tcmalloc (really, non-base/allocator) builds work again,
(i.e. this is a plain vanilla build used when layers like base/allocator
are getting in the way of debugging)
and make sure they use msvcrt rather than libcmt
(libcmt is used to help shim malloc/free, but it gets
in the way of valgrind doing the same thing).

Sadly, this is now a gyp-time operation rather than a Configuration
option.

Had to remove hardcoded C prototype for _set_new_mode, 
as that caused link errors.

Also add variables win_{release,debug}_{Optimization,RuntimeLibrary}
to let the valgrind build override those settings.

Fix calling convention on _set_new_mode to match the
one in <new.h>

BUG=none
TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33719

[dank, 2009-12-03 00:39:17]

Still have to figure out the _set_new_mode()
link error -- seems one environment declares it
as extern "C", another declares it as extern "C++".

Otherwise does it look ok?

[bradn, 2009-12-03 00:54:51]

LGTM, other than one concern

http://codereview.chromium.org/455037/diff/2001/3007
File build/common.gypi (right):

http://codereview.chromium.org/455037/diff/2001/3007#newcode873
build/common.gypi:873: 'msvs_disabled_warnings': [4396, 4503, 4819, 4275],
I gather this needs to be on for tcmalloc. Any chance this could be conditional
too? Best to keep as many warnings on as possible.

[willchan no longer on Chromium, 2009-12-03 01:00:51]

I'm taking a peek right now.  I don't think we should be using the name
win_use_tcmalloc as the gyp variable, as the allocator library is really an
allocator shim that lets you choose different allocators.  Maybe
win_use_allocator_shim.

On 2009/12/03 00:54:51, bradn wrote:
> LGTM, other than one concern
> 
> http://codereview.chromium.org/455037/diff/2001/3007
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/455037/diff/2001/3007#newcode873
> build/common.gypi:873: 'msvs_disabled_warnings': [4396, 4503, 4819, 4275],
> I gather this needs to be on for tcmalloc. Any chance this could be
conditional
> too? Best to keep as many warnings on as possible.

[willchan no longer on Chromium, 2009-12-03 01:03:24]

Skimmed through it now.  Everything else seems reasonable to me.

[dank, 2009-12-03 18:38:20]

Please have another look.  I changed the variable name,
made the doc more precise, fixed the linking error
(by forcing our _set_new_mode to have same signature
as the one in <new.h>), and made the warning conditional
and better-documented.

[dank, 2009-12-03 21:00:09]

Trybots happy.  OK to commit?

[willchan no longer on Chromium, 2009-12-03 21:01:44]

Fine by me.

On Thu, Dec 3, 2009 at 1:00 PM,  <dank@chromium.org> wrote:
> Trybots happy.  OK to commit?
>
> http://codereview.chromium.org/455037
>