Issue 4508004: gtk: refactor copy-pasted code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4508004: gtk: refactor copy-pasted code (Closed)

Created:
10 years, 1 month ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade, piman

CC:
chromium-reviews, jam, darin-cc_chromium.org, apatrick_chromium, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

gtk: refactor copy-pasted code I wanted to do the same thing in a third place. TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65246

Patch Set 1 #

Total comments: 3

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -32 lines)			Patch
M	chrome/gpu/gpu_thread.cc	View	2 chunks	+2 lines, -16 lines	0 comments	Download
M	chrome/plugin/plugin_thread.cc	View	2 chunks	+2 lines, -16 lines	0 comments	Download
M	gfx/gtk_util.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gfx/gtk_util.cc	View	2 chunks	+19 lines, -0 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

10 years, 1 month ago (2010-11-05 20:35:03 UTC) #3

lgtm

http://codereview.chromium.org/4508004/diff/1/4
File gfx/gtk_util.cc (right):

http://codereview.chromium.org/4508004/diff/1/4#newcode59
gfx/gtk_util.cc:59: scoped_array<char *> argv(new char *[argc + 1]);
are these weird spaces necessary?

http://codereview.chromium.org/4508004/diff/1/4#newcode61
gfx/gtk_util.cc:61: // TODO(piman@google.com): can gtk_init modify argv? Just
being safe
I think you can just remove the comment

http://codereview.chromium.org/4508004/diff/1/4#newcode66
gfx/gtk_util.cc:66: char **argv_pointer = argv.get();
* on left

Expand Messages | Collapse Messages