gtk: refactor copy-pasted code

gfx/gtk_util.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gfx/gtk_util.h"
 
 #include <gdk/gdk.h>
 #include <gtk/gtk.h>
 #include <stdlib.h>
 
 #include "base/basictypes.h"
+#include "base/command_line.h"
 #include "base/linux_util.h"
 #include "gfx/rect.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkUnPreMultiply.h"
 
 namespace {
 
 void FreePixels(guchar* pixels, gpointer data) {
   free(data);
 }
@@ skipping 23 matching lines @@
     }
   }
 
   return ret;
 }
 
 }  // namespace
 
 namespace gfx {
 
+void GtkInitFromCommandLine(const CommandLine& command_line) {
+  const std::vector<std::string>& args = command_line.argv();
+  int argc = args.size();
+  scoped_array<char *> argv(new char *[argc + 1]);

[Evan Stade, 2010/11/05 20:35:03]

are these weird spaces necessary?

+  for (size_t i = 0; i < args.size(); ++i) {
+    // TODO(piman@google.com): can gtk_init modify argv? Just being safe

[Evan Stade, 2010/11/05 20:35:03]

I think you can just remove the comment

+    // here.
+    argv[i] = strdup(args[i].c_str());
+  }
+  argv[argc] = NULL;
+  char **argv_pointer = argv.get();

[Evan Stade, 2010/11/05 20:35:03]

* on left

+
+  gtk_init(&argc, &argv_pointer);
+  for (size_t i = 0; i < args.size(); ++i) {
+    free(argv[i]);
+  }
+}
+
 GdkPixbuf* GdkPixbufFromSkBitmap(const SkBitmap* bitmap) {
   if (bitmap->isNull())
     return NULL;
 
   bitmap->lockPixels();
 
   int width = bitmap->width();
   int height = bitmap->height();
   int stride = bitmap->rowBytes();
 
@@ skipping 84 matching lines @@
       new_pixels[idx + 1] = pixels[idx + 1];
       new_pixels[idx + 2] = pixels[idx];
       new_pixels[idx + 3] = pixels[idx + 3];
     }
   }
 
   return new_pixels;
 }
 
 }  // namespace gfx