Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 4501001: VM: Use -serial none in no-graphics kvm mode... (Closed)

Created:
10 years, 1 month ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, Daniel Kurtz
Visibility:
Public.

Description

VM: Use -serial none in no-graphics kvm mode... ...so that the console doesn't get messed up due to the serial port being redirected from stdin. BUG=8729 TEST=./bin/cros_run_parallel_vm_tests suite_Smoke suite_Smoke; checked console Change-Id: I5a0cedba2b0ac7f453b4574666c645e84b30b379 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4b029a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M bin/cros_run_parallel_vm_tests.py View 2 chunks +1 line, -6 lines 0 comments Download
M lib/cros_vm_lib.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
Thanks to djkurtz for figuring the right fix.
10 years, 1 month ago (2010-11-04 20:56:58 UTC) #1
sosa
10 years, 1 month ago (2010-11-04 21:04:41 UTC) #2
LGTM thanks for fixing this ... this means less open dead terminals for me!

Powered by Google App Engine
This is Rietveld 408576698