Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: bin/cros_run_parallel_vm_tests.py

Issue 4501001: VM: Use -serial none in no-graphics kvm mode... (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/cros_vm_lib.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cros_run_parallel_vm_tests.py
diff --git a/bin/cros_run_parallel_vm_tests.py b/bin/cros_run_parallel_vm_tests.py
index b6403bfe65b3905e36ebbbf2c777c02524e60a90..0c0b08b88ac0e6031d20cf0e00f967752bfa6a6d 100755
--- a/bin/cros_run_parallel_vm_tests.py
+++ b/bin/cros_run_parallel_vm_tests.py
@@ -64,10 +64,6 @@ class ParallelTestRunner(object):
"""
ssh_port = self._base_ssh_port
spawned_tests = []
- # Test runs shouldn't need anything from stdin. However, it seems that
- # running with stdin leaves the terminal in a bad state so redirect from
- # /dev/null.
- dev_null = open('/dev/null')
for test in self._tests:
args = [ os.path.join(os.path.dirname(__file__), 'cros_run_vm_test'),
'--snapshot', # The image is shared so don't modify it.
@@ -84,8 +80,7 @@ class ParallelTestRunner(object):
if self._order_output:
output = tempfile.NamedTemporaryFile(prefix='parallel_vm_test_')
Info('Piping output to %s.' % output.name)
- proc = subprocess.Popen(args, stdin=dev_null, stdout=output,
- stderr=output)
+ proc = subprocess.Popen(args, stdout=output, stderr=output)
test_info = { 'test': test,
'proc': proc,
'output': output }
« no previous file with comments | « no previous file | lib/cros_vm_lib.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698