crash-reporter: Ignore Chrome crashes, relying on Chrome breakpad

user_collector.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crash-reporter/user_collector.h"
 
 #include <fcntl.h>  // For creat.
 #include <grp.h>  // For struct group.
 #include <pwd.h>  // For struct passwd.
 #include <sys/types.h>  // For getpwuid_r, getgrnam_r, WEXITSTATUS.
@@ skipping 423 matching lines @@
       (FLAGS_filter_in == "none" ||
        FLAGS_filter_in != exec)) {
     // We use a different format message to make it more obvious in tests
     // which crashes are test generated and which are real.
     logger_->LogWarning("Ignoring crash from %s[%d] while filter_in=%s",
                         exec.c_str(), pid, FLAGS_filter_in.c_str());
     return true;
   }
 
   bool feedback = is_feedback_allowed_function_();
+  const char *handling_string = "handling";
+  if (!feedback) {
+    handling_string = "ignoring - no consent";
+  }
+
+  // Treat Chrome crashes as if the user opted-out.  We stop counting Chrome
+  // crashes towards user crashes, so user crashes really mean non-Chrome
+  // user-space crashes.
+  if (exec == "chrome") {
+    feedback = false;

[petkov, 2010/11/09 23:30:12]

probably doesn't matter but feedback may be false already. not sure if you care
to mark these as ignoring because it's chrome or ignoring because there's no
consent. or maybe you want a separate string.

+    handling_string = "ignoring - chrome crash";
+  }
+
   logger_->LogWarning("Received crash notification for %s[%d] sig %d (%s)",
-                      exec.c_str(), pid, signal,
-                      feedback ? "handling" : "ignoring - no consent");
+                      exec.c_str(), pid, signal, handling_string);
 
   if (feedback) {
     count_crash_function_();
 
     if (generate_diagnostics_) {
       bool out_of_capacity = false;
       if (!ConvertAndEnqueueCrash(pid, exec, &out_of_capacity)) {
         if (!out_of_capacity)
           EnqueueCollectionErrorLog(pid, exec);
         return false;
       }
     }
   }
 
   return true;
 }