Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: user_collector.cc

Issue 4499006: crash-reporter: Ignore Chrome crashes, relying on Chrome breakpad (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git@master
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | user_collector_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: user_collector.cc
diff --git a/user_collector.cc b/user_collector.cc
index 02025c20d9db86a53b3193e4c5474721a42cd1e1..7a1a7cb5cbbd977cc48e6ef63780453b6b7f9f09 100644
--- a/user_collector.cc
+++ b/user_collector.cc
@@ -441,9 +441,21 @@ bool UserCollector::HandleCrash(int signal, int pid, const char *force_exec) {
}
bool feedback = is_feedback_allowed_function_();
+ const char *handling_string = "handling";
+ if (!feedback) {
+ handling_string = "ignoring - no consent";
+ }
+
+ // Treat Chrome crashes as if the user opted-out. We stop counting Chrome
+ // crashes towards user crashes, so user crashes really mean non-Chrome
+ // user-space crashes.
+ if (exec == "chrome") {
+ feedback = false;
petkov 2010/11/09 23:30:12 probably doesn't matter but feedback may be false
+ handling_string = "ignoring - chrome crash";
+ }
+
logger_->LogWarning("Received crash notification for %s[%d] sig %d (%s)",
- exec.c_str(), pid, signal,
- feedback ? "handling" : "ignoring - no consent");
+ exec.c_str(), pid, signal, handling_string);
if (feedback) {
count_crash_function_();
« no previous file with comments | « no previous file | user_collector_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698