Merge 65079 - Remove component extensions Calendar and Docs...

Merge 65079 - Remove component extensions Calendar and Docs

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8662
TEST=manual

Review URL: http://codereview.chromium.org/4411001

TBR=dpolukhin@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65082

[Aaron Boodman, 2010-11-04 21:31:07]

http://codereview.chromium.org/4478003/diff/1/2
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/4478003/diff/1/2#newcode27
chrome/browser/extensions/default_apps.cc:27: #endif  // OS_CHROMEOS
One thing I just realized: I think that this will break the display of the app
store promo in Chrome OS. This is what was scaring me about having Chrome OS do
things differently.

:: despair ::

[Dmitry Polukhin, 2010-11-05 06:39:29]

http://codereview.chromium.org/4478003/diff/1/2
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/4478003/diff/1/2#newcode27
chrome/browser/extensions/default_apps.cc:27: #endif  // OS_CHROMEOS
On 2010/11/04 21:31:07, Aaron Boodman wrote:
> One thing I just realized: I think that this will break the display of the app
> store promo in Chrome OS. This is what was scaring me about having Chrome OS
do
> things differently.
> 
> :: despair ::

Indeed, I don't see it anymore. I'll take a look how to return it back in Chrome
OS on Monday. Return it in R9x - it should be relatively easy.

I worked with apps in Chrome OS for long time, logged in with lots of new
profiles, etc. and noticed it only recently :) It is very unobtrusive.

[Dmitry Polukhin, 2010-11-08 16:19:38]

I read the code and it looks like default apps promo never worked on Chrome OS
as it design to be.

DefaultApps::ShouldShowPromo doesn't take into account external extensions. It
shows promo if list of current installed apps exactly matches list of default
apps. Therefore if any extension was installed via external_extensions.json
file, promo won't be shown (only by mistake if due to errors none was installed
from external_extensions.json). Extensions installed via sync also inhibit
promo.

We need to find new rules for showing promo and not only for Chrome OS case.
Also we should take into account different machines so it should be syncable
option that will be reset as soon as user manually installs app and syncable
counter how many times promo was shown (need to register option in
chrome/browser/sync/glue/synchronized_preferences.h).

[Aaron Boodman, 2010-11-11 02:24:00]

On 2010/11/08 16:19:38, Dmitry Polukhin wrote:
> DefaultApps::ShouldShowPromo doesn't take into account external extensions. It
> shows promo if list of current installed apps exactly matches list of default
> apps. Therefore if any extension was installed via external_extensions.json
> file, promo won't be shown (only by mistake if due to errors none was
installed
> from external_extensions.json).

Yes, that is what I meant when I said that moving default apps to
external_extensions.json would break this.

> Extensions installed via sync also inhibit promo.

Only if they sync an app that is not part of the default set, right? That is by
design. The promo is supposed to go away once any app is installed that is not
part of the default set.

> We need to find new rules for showing promo and not only for Chrome OS case.

As far as I know it is working in desktop Chrome, but I do agree that it would
be nice to have things work the same way on all platforms.

> Also we should take into account different machines so it should be syncable
> option that will be reset as soon as user manually installs app and syncable
> counter how many times promo was shown (need to register option in
> chrome/browser/sync/glue/synchronized_preferences.h).

I don't follow why the preference needs to be synced.

[Dmitry Polukhin, 2010-11-11 08:59:56]

> > Also we should take into account different machines so it should be syncable
> > option that will be reset as soon as user manually installs app and syncable
> > counter how many times promo was shown (need to register option in
> > chrome/browser/sync/glue/synchronized_preferences.h).
> 
> I don't follow why the preference needs to be synced.

If user doesn't touch set of apps, he will see promo 10 times on each machine.
Moreover on Chrome OS it is very easy to remove local profile and login again
expecting that all will be synced. Such user will see promo 10 times more. If he
removes profile frequently or changes machines frequently, he will see promo all
the time until he changes set of default apps. So "10 times" rule won't work if
it is important it needs to be synced.

[Aaron Boodman, 2010-11-11 19:09:19]

On Thu, Nov 11, 2010 at 12:59 AM,  <dpolukhin@chromium.org> wrote:
> If user doesn't touch set of apps, he will see promo 10 times on each
> machine.
> Moreover on Chrome OS it is very easy to remove local profile and login
> again
> expecting that all will be synced. Such user will see promo 10 times more.
> If he
> removes profile frequently or changes machines frequently, he will see promo
> all
> the time until he changes set of default apps. So "10 times" rule won't work
> if
> it is important it needs to be synced.

Thanks for explaining. I think these behaviors are acceptable, but I
can see your point. Other parts of the NTP have this same issue.

- a