Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 4478003: Merge 65079 - Remove component extensions Calendar and Docs... (Closed)

Created:
10 years, 1 month ago by Dmitry Polukhin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 65079 - Remove component extensions Calendar and Docs BUG=http://code.google.com/p/chromium-os/issues/detail?id=8662 TEST=manual Review URL: http://codereview.chromium.org/4411001 TBR=dpolukhin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65082

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/default_apps.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Polukhin
10 years, 1 month ago (2010-11-04 18:11:54 UTC) #1
Aaron Boodman
http://codereview.chromium.org/4478003/diff/1/2 File chrome/browser/extensions/default_apps.cc (right): http://codereview.chromium.org/4478003/diff/1/2#newcode27 chrome/browser/extensions/default_apps.cc:27: #endif // OS_CHROMEOS One thing I just realized: I ...
10 years, 1 month ago (2010-11-04 21:31:07 UTC) #2
Dmitry Polukhin
http://codereview.chromium.org/4478003/diff/1/2 File chrome/browser/extensions/default_apps.cc (right): http://codereview.chromium.org/4478003/diff/1/2#newcode27 chrome/browser/extensions/default_apps.cc:27: #endif // OS_CHROMEOS On 2010/11/04 21:31:07, Aaron Boodman wrote: ...
10 years, 1 month ago (2010-11-05 06:39:29 UTC) #3
Dmitry Polukhin
I read the code and it looks like default apps promo never worked on Chrome ...
10 years, 1 month ago (2010-11-08 16:19:38 UTC) #4
Aaron Boodman
On 2010/11/08 16:19:38, Dmitry Polukhin wrote: > DefaultApps::ShouldShowPromo doesn't take into account external extensions. It ...
10 years, 1 month ago (2010-11-11 02:24:00 UTC) #5
Dmitry Polukhin
> > Also we should take into account different machines so it should be syncable ...
10 years, 1 month ago (2010-11-11 08:59:56 UTC) #6
Aaron Boodman
10 years, 1 month ago (2010-11-11 19:09:19 UTC) #7
On Thu, Nov 11, 2010 at 12:59 AM,  <dpolukhin@chromium.org> wrote:
> If user doesn't touch set of apps, he will see promo 10 times on each
> machine.
> Moreover on Chrome OS it is very easy to remove local profile and login
> again
> expecting that all will be synced. Such user will see promo 10 times more.
> If he
> removes profile frequently or changes machines frequently, he will see promo
> all
> the time until he changes set of default apps. So "10 times" rule won't work
> if
> it is important it needs to be synced.

Thanks for explaining. I think these behaviors are acceptable, but I
can see your point. Other parts of the NTP have this same issue.

- a

Powered by Google App Engine
This is Rietveld 408576698