Remove component extensions Calendar and Docs

Remove component extensions Calendar and Docs

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8662
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65079

[Dmitry Polukhin, 2010-11-03 21:19:18]

http://codereview.chromium.org/4411001/diff/1/2
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/4411001/diff/1/2#newcode24
chrome/browser/extensions/default_apps.cc:24: #if !defined(OS_CHROMEOS)
Erik, what do you think about removing all these apps from this list and adding
GMail to external_extensions.json file - it will have benefit that Chrome OS
image will have cached version of corresponding .crx file. Also perhaps it make
sense to do for all platforms.

[Erik does not do reviews, 2010-11-03 21:29:40]

I'd like Aaron to review this instead since the default apps code is his.

[Aaron Boodman, 2010-11-04 04:22:59]

lgtm

http://codereview.chromium.org/4411001/diff/1/2
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/4411001/diff/1/2#newcode24
chrome/browser/extensions/default_apps.cc:24: #if !defined(OS_CHROMEOS)
On 2010/11/03 21:19:18, Dmitry Polukhin wrote:
> Erik, what do you think about removing all these apps from this list and
adding
> GMail to external_extensions.json file - it will have benefit that Chrome OS
> image will have cached version of corresponding .crx file. Also perhaps it
make
> sense to do for all platforms.

I don't want to change the way this works on desktop Chrome right now. We know
that the current code works and we are happy with it.

If we eventually implement something like what Chrome OS has where the
extensions are baked into the image then we can revisit.

[Dmitry Polukhin, 2010-11-04 06:38:13]

http://codereview.chromium.org/4411001/diff/1/2
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/4411001/diff/1/2#newcode24
chrome/browser/extensions/default_apps.cc:24: #if !defined(OS_CHROMEOS)
On 2010/11/04 04:23:00, Aaron Boodman wrote:
> I don't want to change the way this works on desktop Chrome right now. We know
> that the current code works and we are happy with it.
> 
> If we eventually implement something like what Chrome OS has where the
> extensions are baked into the image then we can revisit.

Sounds reasonable. In this case I'll do it only for Chrome OS: all default apps
will be managed in one place - i.e. external_extensions.json and they will have
cached version. I think there is no sense to make GMail special and manage it
here.

[Aaron Boodman, 2010-11-04 16:57:03]

http://codereview.chromium.org/4411001/diff/1/2
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/4411001/diff/1/2#newcode24
chrome/browser/extensions/default_apps.cc:24: #if !defined(OS_CHROMEOS)
On 2010/11/04 06:38:13, Dmitry Polukhin wrote:
> On 2010/11/04 04:23:00, Aaron Boodman wrote:
> > I don't want to change the way this works on desktop Chrome right now. We
know
> > that the current code works and we are happy with it.
> > 
> > If we eventually implement something like what Chrome OS has where the
> > extensions are baked into the image then we can revisit.
> 
> Sounds reasonable. In this case I'll do it only for Chrome OS: all default
apps
> will be managed in one place - i.e. external_extensions.json and they will
have
> cached version. I think there is no sense to make GMail special and manage it
> here.

Ok, I'll leave it to you to decide what to do for Chrome OS. Just please don't
change desktop Chrome.