Issue 4465001: Reduce the chances for gclient to throw an exception in subprocess module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4465001: Reduce the chances for gclient to throw an exception in subprocess module. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Reduce the chances for gclient to throw an exception in subprocess module. Python standard library is not thread safe. Work around it by leaking a bit. The problem is particularly visible on python 2.4. TEST=none BUG=60623 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65048

Patch Set 1 #

Patch Set 2 : fix license and unit test #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	gclient_utils.py	View	1	3 chunks	+12 lines, -13 lines	0 comments	Download
	M	tests/gclient_utils_test.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

10 years, 1 month ago (2010-11-04 08:05:50 UTC) #2

lgtm (although it actually more looks like a hack to me...)

btw, why does this file have a different license?

Expand Messages | Collapse Messages