tests/gclient_utils_test.py - Issue 4465001: Reduce the chances for gclient to throw an exception in subprocess module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gclient_utils_test.py

Issue 4465001: Reduce the chances for gclient to throw an exception in subprocess module. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: fix license and unit test Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gclient_utils_test.py

diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py

index 934e4bb99226507f9485de02d08c832d1c99b5dd..aa759ffb02201489abaa2842f13d434eea96ae77 100755

--- a/tests/gclient_utils_test.py

+++ b/tests/gclient_utils_test.py

@@ -30,8 +30,8 @@ class GclientUtilsUnittest(GclientUtilBase):

'ParseXML', 'Popen',

'PrintableObject', 'RemoveDirectory', 'SoftClone', 'SplitUrlRevision',

'SyntaxErrorToError', 'WorkItem',

- 'errno', 'logging', 'os', 'Queue', 're', 'stat', 'subprocess',

- 'sys','threading', 'time', 'xml',

+ 'errno', 'hack_subprocess', 'logging', 'os', 'Queue', 're', 'stat',

+ 'subprocess', 'sys','threading', 'time', 'xml',

]

# If this test fails, you should add the relevant test.

self.compareMembers(gclient_utils, members)

« no previous file with comments | « gclient_utils.py ('k') | no next file » | no next file with comments »