Minimalist breakpad implementation.

Minimalist breakpad implementation.

Client-side implementation.

TODO: Need to automatically disable it for unit tests.

[Nicolas Sylvain, 2009-11-30 04:23:16]

why?

On Wed, Nov 25, 2009 at 6:16 PM, <maruel@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Minimalist breakpad implementation.
>
> Client-side implementation.
>
> TODO: Need to automatically disable it for unit tests.
>
> Please review this at http://codereview.chromium.org/444009
>
> Affected files:
>  A breakpad.py
>  M drover.py
>  M gcl.py
>  M gclient.py
>  M git_cl_hooks.py
>
>
> Index: breakpad.py
> diff --git a/breakpad.py b/breakpad.py
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..e469e1e5bd851bc1347fe17b12870957d21d69f3
> --- /dev/null
> +++ b/breakpad.py
> @@ -0,0 +1,35 @@
> +# Copyright (c) 2009 The Chromium Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +
> +"""Sends a notification when a process stops on an exception."""
> +
> +import atexit
> +import getpass
> +import urllib
> +import traceback
> +import sys
> +
> +
> +def SendStack(stack, url='http://chromium-status.appspot.com/breakpad'):
> +  print('WARNING: I am about to send a stack trace and your username so I
> am '
> +        'able to help you fix the failure you just got. Thanks for your '
> +        'comprehension.')
> +  try:
> +    params = {
> +        'args': sys.argv,
> +        'stack': stack,
> +        'user': getpass.getuser(),
> +    }
> +    request = urllib.urlopen(url, urllib.urlencode(params))
> +    print request.read()
> +    request.close()
> +  except IOError:
> +    print('There was a failure while trying to send the stack trace. Too
> bad.')
> +
> +
> +@atexit.register
> +def CheckForException():
> +  last_tb = getattr(sys, 'last_traceback', None)
> +  if last_tb:
> +    SendStack(''.join(traceback.format_tb(last_tb)))
> Index: drover.py
> diff --git a/drover.py b/drover.py
> index
>
99eafb2cbb5e7a8075d0a23baa6834d149bb24a5..f19308a411bd82b85ccb1609afa339ae4a19ab00
> 100644
> --- a/drover.py
> +++ b/drover.py
> @@ -9,6 +9,8 @@ import subprocess
>  import sys
>  import webbrowser
>
> +import breakpad
> +
>  USAGE = """
>  WARNING: Please use this tool in an empty directory
>  (or at least one that you don't mind clobbering.)
> Index: gcl.py
> diff --git a/gcl.py b/gcl.py
> index
>
e4b50859d68314ff6b065777767d20088ac765e3..7698da609029bf91cfd45c8b5d5bfde2b86656ec
> 100755
> --- a/gcl.py
> +++ b/gcl.py
> @@ -18,6 +18,8 @@ import tempfile
>  import upload
>  import urllib2
>
> +import breakpad
> +
>  # gcl now depends on gclient.
>  from scm import SVN
>  import gclient_utils
> Index: gclient.py
> diff --git a/gclient.py b/gclient.py
> index
>
9edadc2c86f4e5da834fb604233bc564f8016f3d..e42072f0ffb775ee4574c650579a0f060d152b90
> 100755
> --- a/gclient.py
> +++ b/gclient.py
> @@ -78,6 +78,8 @@ import sys
>  import urlparse
>  import urllib
>
> +import breakpad
> +
>  import gclient_scm
>  import gclient_utils
>
> Index: git_cl_hooks.py
> diff --git a/git_cl_hooks.py b/git_cl_hooks.py
> index
>
1e153f006085551ba9045f7c89c860fa50c13eb4..81d48cea049b0a1c9f6f12e64a3e31d814a8c78f
> 100644
> --- a/git_cl_hooks.py
> +++ b/git_cl_hooks.py
> @@ -7,6 +7,8 @@ import re
>  import subprocess
>  import sys
>
> +import breakpad
> +
>  import presubmit_support
>  import scm
>
>
>
>

[M-A Ruel, 2009-11-30 14:26:06]

On 2009/11/30 04:23:16, Nicolas Sylvain wrote:
> why?

Because people don't always warn me when there is a problem in gclient/gcl. With
this, I'll get an alert by IM so I can fix it way faster.