Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 4421002: Make presubmit lint the "include" dir. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make presubmit lint the "include" dir. Make include dir content pass lint.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M include/v8.h View 10 chunks +17 lines, -17 lines 0 comments Download
M include/v8-debug.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
10 years, 1 month ago (2010-11-04 09:41:02 UTC) #1
Søren Thygesen Gjesse
10 years, 1 month ago (2010-11-04 09:55:40 UTC) #2
LGTM! (it has been more than 2 years since the include directory was called
public)

Powered by Google App Engine
This is Rietveld 408576698