Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/util/master_preferences.cc

Issue 441008: Many changes to DictionaryValues:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/values.cc ('K') | « chrome/installer/util/google_chrome_distribution.cc ('k') | chrome/test/ui/javascript_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/master_preferences.cc
===================================================================
--- chrome/installer/util/master_preferences.cc (revision 32858)
+++ chrome/installer/util/master_preferences.cc (working copy)
@@ -11,10 +11,8 @@
namespace {
const wchar_t* kDistroDict = L"distribution";
+}
-
-} // namespace
-
namespace installer_util {
namespace master_preferences {
const wchar_t kAltFirstRunBubble[] = L"oem_bubble";
@@ -116,14 +114,10 @@
const std::wstring& name,
bool value) {
- bool ret = false;
- if (prefs && !name.empty()) {
- std::wstring key(kDistroDict);
- key.append(L"." + name);
- if (prefs->SetBoolean(key, value))
- ret = true;
- }
- return ret;
+ if (!prefs || name.empty())
+ return false;
+ prefs->SetBoolean(std::wstring(kDistroDict) + L"." + name, value);
+ return true;
}
} // installer_util
« base/values.cc ('K') | « chrome/installer/util/google_chrome_distribution.cc ('k') | chrome/test/ui/javascript_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698