Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/ui/javascript_test_util.cc

Issue 441008: Many changes to DictionaryValues:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/values.cc ('K') | « chrome/installer/util/master_preferences.cc ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/javascript_test_util.cc
===================================================================
--- chrome/test/ui/javascript_test_util.cc (revision 32858)
+++ chrome/test/ui/javascript_test_util.cc (working copy)
@@ -29,10 +29,10 @@
DictionaryValue* dict = static_cast<DictionaryValue*>(root.get());
- DictionaryValue::key_iterator it = dict->begin_keys();
- for (; it != dict->end_keys(); ++it) {
+ for (DictionaryValue::key_iterator it = dict->begin_keys();
+ it != dict->end_keys(); ++it) {
Value* value = NULL;
- bool succeeded = dict->Get(*it, &value);
+ bool succeeded = dict->GetWithoutPathExpansion(*it, &value);
EXPECT_TRUE(succeeded);
if (!succeeded)
« base/values.cc ('K') | « chrome/installer/util/master_preferences.cc ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698