Issue 438005: Enable sync by default on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438005: Enable sync by default on all platforms. (Closed)

Created:
11 years, 1 month ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Enable sync by default on all platforms. BUG=23073 TEST=ran without --enable-sync on OS X, made sure sync UI was still present Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33318 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33342

Patch Set 1 : synced to head #

Patch Set 2 : Fixed exposed unittest breakage. #

Patch Set 3 : Synced to head #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/cocoa/bug_report_window_controller_unittest.mm	View	2	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

akalin (wrong akalin)

Feel free to patch this in and check it in if you need/want to, since ...

11 years ago (2009-11-30 09:10:38 UTC) #3

akalin (wrong akalin)

11 years ago (2009-11-30 18:31:44 UTC) #4

Actually, I'll just check this in now.

On Mon, Nov 30, 2009 at 1:10 AM, Fred Akalin <akalin@google.com> wrote:
> Feel free to patch this in and check it in if you need/want to, since
> I'm still on vacation tomorrow.
>
> On Wed, Nov 25, 2009 at 4:47 PM,  <zork@chromium.org> wrote:
>> LGTM
>>
>> http://codereview.chromium.org/438005
>>
>
>
>
> --
> Frederick Akalin
> Software Engineer
>



-- 
Frederick Akalin
Software Engineer

Expand Messages | Collapse Messages