Issue 437042: Fix using depot_tools from a git checkout on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 437042: Fix using depot_tools from a git checkout on Windows. (Closed)

Created:
11 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix using depot_tools from a git checkout on Windows.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
		gclient.bat	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 1 month ago (2009-11-24 20:45:25 UTC) #2

i can't see the diff because of reitveld, but from the snippet, lgtm



On Tue, Nov 24, 2009 at 11:38 AM, <maruel@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Fix using depot_tools from a git checkout on Windows.
>
> Please review this at http://codereview.chromium.org/437042
>
> Affected files:
>  gclient.bat
>
>
> Index: gclient.bat
> diff --git a/gclient.bat b/gclient.bat
> index
>
fa3c9891c8e6e262a5458b59bb0df8ad6eb5f917..0639defd772137cee65b6263bd0e0dc6a679fa0e
> 100755
> --- a/gclient.bat
> +++ b/gclient.bat
> @@ -11,11 +11,6 @@ setlocal
>  :: This is required with cygwin only.
>  PATH=%~dp0;%PATH%
>
> -:: Shall skip automatic update?
> -IF "%DEPOT_TOOLS_UPDATE%" == "0" GOTO :SKIP_UPDATE
> -:: We can't sync if .\.svn\. doesn't exist.
> -IF NOT EXIST "%~dp0.svn\." GOTO :SKIP_UPDATE
> -
>  :: Will download svn and python.
>  :: If you don't want to install the depot_tools version of these tools,
> remove
>  :: the 'force' option on the next command. The tools won't be installed
> only if
> @@ -23,7 +18,12 @@ IF NOT EXIST "%~dp0.svn\." GOTO :SKIP_UPDATE
>  call "%~dp0bootstrap\win\win_tools.bat" force
>  if errorlevel 1 goto :EOF
>
> -:: Sync the bootstrap directory *only after*.
> +:: Shall skip automatic update?
> +IF "%DEPOT_TOOLS_UPDATE%" == "0" GOTO :SKIP_UPDATE
> +:: We can't sync if .\.svn\. doesn't exist.
> +IF NOT EXIST "%~dp0.svn\." GOTO :SKIP_UPDATE
> +
> +:: Sync the bootstrap directory.
>  call svn up -q "%~dp0bootstrap"
>  :: still continue even in case of error.
>  goto :UPDATE
>
>
>

Expand Messages | Collapse Messages