Remove usage of JSArray in Script object...

Remove usage of JSArray in Script object

Storing a JSArray in the Script object could cause an indirect reference from the compilation cache to a global object to be created. Now the line ends are only stored as a FixedArrya and when that is needed in JavaScript a JSArray copy is created. Changed some of the JavaScript code to cache the line ends in a local variable for better performance.

BUG=http://code.google.com/p/v8/issues/detail?id=528
TEST=test/test-api/Bug528

Committed: http://code.google.com/p/v8/source/detail?r=3374

[Mads Ager (chromium), 2009-11-27 12:15:01]

LGTM with a couple of nits.

http://codereview.chromium.org/434117/diff/1/10
File src/accessors.cc (right):

http://codereview.chromium.org/434117/diff/1/10#newcode318
src/accessors.cc:318: if (!script->line_ends()->IsUndefined()) {
Shouldn't this always be true after InitScriptLineEnds?  Can we just assert that
it is not undefined?

http://codereview.chromium.org/434117/diff/1/3
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/434117/diff/1/3#newcode8559
test/cctest/test-api.cc:8559: CHECK_EQ(2, gc_count);
Does this change fix the issue with eval?  It seems that the function is still
there on the script object?

[Søren Thygesen Gjesse, 2009-11-27 14:09:14]

http://codereview.chromium.org/434117/diff/1/10
File src/accessors.cc (right):

http://codereview.chromium.org/434117/diff/1/10#newcode318
src/accessors.cc:318: if (!script->line_ends()->IsUndefined()) {
On 2009/11/27 12:15:01, Mads Ager wrote:
> Shouldn't this always be true after InitScriptLineEnds?  Can we just assert
that
> it is not undefined?

Done.

http://codereview.chromium.org/434117/diff/1/3
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/434117/diff/1/3#newcode8559
test/cctest/test-api.cc:8559: CHECK_EQ(2, gc_count);
On 2009/11/27 12:15:01, Mads Ager wrote:
> Does this change fix the issue with eval?  It seems that the function is still
> there on the script object?

It does not - I will do that in separate change. The previous check on Android
was plain wrong. The reason the count is 2 here is that the compilation cache
for eval only has two generations.