Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: test/cctest/test-api.cc

Issue 434117: Remove usage of JSArray in Script object... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
===================================================================
--- test/cctest/test-api.cc (revision 3373)
+++ test/cctest/test-api.cc (working copy)
@@ -8527,7 +8527,7 @@
v8::HandleScope scope;
context->Enter();
- Local<v8::Object> obj = v8::Object::New();
+ Local<v8::String> obj = v8::String::New("");
context->SetData(obj);
CompileRun("1");
context->Exit();
@@ -8538,14 +8538,8 @@
if (GetGlobalObjectsCount() == 0) break;
}
CHECK_EQ(0, GetGlobalObjectsCount());
+ CHECK_EQ(2, gc_count);
- // Compilation cache size is different for Android.
-#if defined(ANDROID)
- CHECK_EQ(1, gc_count);
-#else
- CHECK_EQ(5, gc_count);
-#endif
-
// Eval in a function creates reference from the compilation cache to the
// global object.
context = Context::New();
@@ -8562,13 +8556,7 @@
if (GetGlobalObjectsCount() == 0) break;
}
CHECK_EQ(0, GetGlobalObjectsCount());
-
- // Compilation cache size is different for Android.
-#if defined(ANDROID)
- CHECK_EQ(1, gc_count);
-#else
CHECK_EQ(2, gc_count);
-#endif
// Looking up the line number for an exception creates reference from the
// compilation cache to the global object.
@@ -8591,11 +8579,5 @@
if (GetGlobalObjectsCount() == 0) break;
}
CHECK_EQ(0, GetGlobalObjectsCount());
-
- // Compilation cache size is different for Android.
-#if defined(ANDROID)
CHECK_EQ(2, gc_count);
-#else
- CHECK_EQ(5, gc_count);
-#endif
}
« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698