Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 4341: Change cursive/fantasy fonts in test_shell and rebaseline test results accordingly (Closed)

Created:
12 years, 2 months ago by jungshik at Google
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Nicolas Sylvain, eseidel, evanm_chromium.org, tc
Visibility:
Public.

Description

Change the web preferences for cursive and fantasy from 'Apple Chancery' and 'Papyrus' to 'Comic Sans MS' and 'Impact' in test_shell.cc They're selected not because they're the best for cursive and fantasy but because they come with Windows without MS Office or other programs installed. Papyrus ('fantasy') and Script (a good candidate for 'cursive') are only available with MS Office installed. 'Apple Chancery' is not available on Windows and our expected results were bogus (they're just using the default font). Rebaseline tests affected by this change (any test that refers to 'cursive' or 'fantasy' fonts). Remove papyrus.html and apple-chancery.html and add 'comic-sans-ms.html' and 'impact.html' from chrome/font Remove *-expected.txt from layout_test_results/v8/chrome/fonts/* and put them along with html files in layout_tests/chrome/fonts Adjust tests_fixable.txt accordingly. BUG=2303 TEST=pass layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8638 lines, -15533 lines) Patch
M webkit/data/layout_test_results/v8/LayoutTests/css1/font_properties/font-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css1/font_properties/font-expected.png View Binary file 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css1/font_properties/font-expected.txt View 12 chunks +47 lines, -47 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css1/font_properties/font_family-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css1/font_properties/font_family-expected.png View Binary file 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css1/font_properties/font_family-expected.txt View 6 chunks +49 lines, -49 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t1508-c527-font-03-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t1508-c527-font-03-b-expected.png View Binary file 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/css2.1/t1508-c527-font-03-b-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/fast/block/float/016-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/fast/block/float/016-expected.png View Binary file 0 comments Download
M webkit/data/layout_test_results/v8/LayoutTests/fast/block/float/016-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
D webkit/data/layout_test_results/v8/chrome/fonts/apple-chancery-expected.txt View 1 chunk +0 lines, -1151 lines 0 comments Download
D webkit/data/layout_test_results/v8/chrome/fonts/courier-expected.txt View 1 chunk +0 lines, -1151 lines 0 comments Download
D webkit/data/layout_test_results/v8/chrome/fonts/default-expected.txt View 1 chunk +0 lines, -1144 lines 0 comments Download
D webkit/data/layout_test_results/v8/chrome/fonts/helvetica-expected.txt View 1 chunk +0 lines, -1151 lines 0 comments Download
D webkit/data/layout_test_results/v8/chrome/fonts/lucida-grande-expected.txt View 1 chunk +0 lines, -1151 lines 0 comments Download
D webkit/data/layout_test_results/v8/chrome/fonts/papyrus-expected.txt View 1 chunk +0 lines, -1151 lines 0 comments Download
D webkit/data/layout_tests/chrome/fonts/apple-chancery.html View 1 chunk +0 lines, -75 lines 0 comments Download
D webkit/data/layout_tests/chrome/fonts/apple-chancery-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
webkit/data/layout_tests/chrome/fonts/apple-chancery-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/data/layout_tests/chrome/fonts/apple-chancery-expected.txt View 1 chunk +0 lines, -1151 lines 0 comments Download
M webkit/data/layout_tests/chrome/fonts/arial-expected.txt View 1 chunk +850 lines, -850 lines 0 comments Download
A webkit/data/layout_tests/chrome/fonts/comic-sans-ms.html View 1 chunk +75 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/fonts/comic-sans-ms-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/fonts/comic-sans-ms-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/chrome/fonts/comic-sans-ms-expected.txt View 1 chunk +1151 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/chrome/fonts/courier-expected.txt View 2 chunks +658 lines, -658 lines 0 comments Download
M webkit/data/layout_tests/chrome/fonts/default-expected.txt View 1 chunk +1136 lines, -1136 lines 0 comments Download
M webkit/data/layout_tests/chrome/fonts/helvetica-expected.txt View 1 chunk +1126 lines, -1126 lines 0 comments Download
A webkit/data/layout_tests/chrome/fonts/impact.html View 1 chunk +75 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/fonts/impact-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/fonts/impact-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/chrome/fonts/impact-expected.txt View 1 chunk +1151 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/chrome/fonts/lucida-grande-expected.txt View 1 chunk +1144 lines, -1144 lines 0 comments Download
D webkit/data/layout_tests/chrome/fonts/papyrus.html View 1 chunk +0 lines, -75 lines 0 comments Download
D webkit/data/layout_tests/chrome/fonts/papyrus-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
webkit/data/layout_tests/chrome/fonts/papyrus-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/data/layout_tests/chrome/fonts/papyrus-expected.txt View 1 chunk +0 lines, -1151 lines 0 comments Download
M webkit/data/layout_tests/chrome/fonts/times-expected.txt View 1 chunk +1140 lines, -1140 lines 0 comments Download
M webkit/tools/layout_tests/test_lists/tests_fixable.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +10 lines, -2 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
jungshik at Google
12 years, 2 months ago (2008-09-29 23:13:08 UTC) #1
eroman
lgtm. Looping in eseidel, in case it will be easier for webkit-merge effort to submit ...
12 years, 2 months ago (2008-09-29 23:56:32 UTC) #2
macdome_gmail.com
Probably easier to deal with this tomorrow, after we land... Evan and tony have been ...
12 years, 2 months ago (2008-09-30 00:01:48 UTC) #3
tony
I was going to say the same thing. Please wait until after the merge lands ...
12 years, 2 months ago (2008-09-30 00:06:55 UTC) #4
Pam (message me for reviews)
LGTM, with the caveats already noted by others. These expected results files aren't in exactly ...
12 years, 2 months ago (2008-09-30 00:15:44 UTC) #5
jungshik at Google
Thank you all for taking a look. I'll land when the tree is open again. ...
12 years, 2 months ago (2008-10-03 00:40:08 UTC) #6
jungshik at Google
12 years, 2 months ago (2008-10-03 00:40:29 UTC) #7
http://codereview.chromium.org/4341/diff/1/201
File webkit/tools/test_shell/test_shell.cc (right):

http://codereview.chromium.org/4341/diff/1/201#newcode239
Line 239: // enumerating all the fonts available on Windows XP. Some of
On 2008/09/29 23:56:32, eroman wrote:
> Are these solid choices for Vista as well?

Yes, they're in the sense that both are available on Vista as well as XP. I
changed the comment to refer to the Vista font list as well.

Powered by Google App Engine
This is Rietveld 408576698