Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: webkit/tools/test_shell/test_shell.cc

Issue 4341: Change cursive/fantasy fonts in test_shell and rebaseline test results accordingly (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/layout_tests/test_lists/tests_fixable.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_shell.cc
===================================================================
--- webkit/tools/test_shell/test_shell.cc (revision 2687)
+++ webkit/tools/test_shell/test_shell.cc (working copy)
@@ -234,8 +234,16 @@
web_prefs_->fixed_font_family = L"Courier";
web_prefs_->serif_font_family = L"Times";
web_prefs_->sans_serif_font_family = L"Helvetica";
- web_prefs_->cursive_font_family = L"Apple Chancery";
- web_prefs_->fantasy_font_family = L"Papyrus";
+ // These two fonts are picked from the list at
+ // http://www.microsoft.com/typography/fonts/winxp.htm
+ // enumerating all the fonts available on Windows XP. Some of
eroman 2008/09/29 23:56:32 Are these solid choices for Vista as well?
jungshik at Google 2008/10/03 00:40:29 Yes, they're in the sense that both are available
+ // them are installed only with CJK and Complex script
+ // support enabled and are out of consideration here.
+ // They (especially Impact for fantasy) are not typical cursive
+ // and fantasy fonts, but it should not matter for layout tests
+ // as long as they're available.
+ web_prefs_->cursive_font_family = L"Comic Sans MS";
+ web_prefs_->fantasy_font_family = L"Impact";
web_prefs_->default_encoding = L"ISO-8859-1";
web_prefs_->default_font_size = 16;
web_prefs_->default_fixed_font_size = 13;
« no previous file with comments | « webkit/tools/layout_tests/test_lists/tests_fixable.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698