Build IBus packages.

Build IBus packages.
This change depends on http://codereview.chromium.org/438015.

- scripts/build_platform_packages.sh

Run third_party/{ibus, ibus-chewing, ibus-anthy}/make_pkg.sh scripts in order to create IBus debian packages.

- third_party/ibus/make_pkg.sh
- third_party/ibus-chewing/make_pkg.sh
- third_party/ibus-anthy/make_pkg.sh

New files.

- third_party/ibus-chewing/ibus-chewing_1.2.0.20090818-2.diff.gz
- third_party/ibus-anthy/ibus-anthy_1.2.0.20090813-2.diff.gz

New files. These patch files create debian/ directories under third_party/ibus-chewing/ and third_party/ibus-anthy/ respectively.
These files are copied from Ubuntu Karmic's deb source packages like third_party/clutter/clutter-1.0_1.0.4-0ubuntu1.diff.gz (I believe it's okay, but let me double-check).

- package_repo/package-list-prod.txt
- package_repo/repo_list_image.txt

Add IBus packages to the rootfs image.

- package_repo/package-list-dev.txt

Add debian packages that are necessary to build IBus packages. Please note that autopoint script in gettext package requires cvs for unknown reasons.

- package_repo/repo_list_dev.txt

* IBus code requires slightly newer version of Gtk+/Glib. Upgraded them from 2.17.2-0ubuntu2 to 2.17.7-0ubuntu3 (Gtk+), from 2.21.2-0ubuntu1 to 2.21.4-0ubuntu1 (Glib).
* cmake-data depends on emacsen-common and update-indetd.
* python-gobject-dev depends on libffi-dev.
* python2.6-dev is required, but python2.6-dev_2.6.2-0ubuntu2 is not available on Ubuntu (I don't know why). Therefore, upgraded all python2.6* packages from 2.6.2-0ubuntu2 to 2.6.2-0ubuntu3.

[Daniel Erat, 2009-11-24 15:30:18]

Just a quick look -- you probably should get someone more familiar with the repo
stuff to review this.

http://codereview.chromium.org/434033/diff/1001/1003
File src/package_repo/package-list-prod.txt (right):

http://codereview.chromium.org/434033/diff/1001/1003#newcode92
src/package_repo/package-list-prod.txt:92: python-ibus
Are you sure you need this?  I'm pretty sure we don't want a python dependency
long-term.

http://codereview.chromium.org/434033/diff/1001/1004
File src/package_repo/repo_list_dev.txt (right):

http://codereview.chromium.org/434033/diff/1001/1004#newcode86
src/package_repo/repo_list_dev.txt:86: emacsen-common 1.4.19ubuntu1 optional
editors pool/main/e/emacsen-common/emacsen-common_1.4.19ubuntu1_all.deb
Remove this?  Some of these are packages that you installed locally but that
aren't actually required in the repo, right?

(Disclaimer: I am a vi user.)

http://codereview.chromium.org/434033/diff/1001/1004#newcode248
src/package_repo/repo_list_dev.txt:248: libgtk2.0-0 2.17.7-0ubuntu3 optional
libs pool/main/g/gtk+2.0/libgtk2.0-0_2.17.7-0ubuntu3_i386.deb
You might want to check with sky@ about this -- he was suspecting that the old
version might've been responsible for the white-boxes-in-the-tab-strip drawing
bug that we've been seeing.  He and I both had trouble when we tried 2.18, but
it's possible that this version works and fixes the bug.

http://codereview.chromium.org/434033/diff/1001/1004#newcode558
src/package_repo/repo_list_dev.txt:558: update-inetd 4.31 optional admin
pool/main/u/update-inetd/update-inetd_4.31_all.deb
Where did this come from?

[Yusuke Sato, 2009-11-24 16:24:43]

Thanks Daniel for the review.

http://codereview.chromium.org/434033/diff/1001/1003
File src/package_repo/package-list-prod.txt (right):

http://codereview.chromium.org/434033/diff/1001/1003#newcode92
src/package_repo/package-list-prod.txt:92: python-ibus
We (yusukes and satorux) are planning to remove the python dependency by
reimplementing IME modules written in Python in C++. But for the first few
mohtns, we'd like to use these python IME modules as-is.

On 2009/11/24 15:30:18, Daniel Erat wrote:
> Are you sure you need this?  I'm pretty sure we don't want a python dependency
> long-term.

http://codereview.chromium.org/434033/diff/1001/1004
File src/package_repo/repo_list_dev.txt (right):

http://codereview.chromium.org/434033/diff/1001/1004#newcode86
src/package_repo/repo_list_dev.txt:86: emacsen-common 1.4.19ubuntu1 optional
editors pool/main/e/emacsen-common/emacsen-common_1.4.19ubuntu1_all.deb
Actually cmake-data which is required to build IBus-Chewing requires
emacsen-common...

On 2009/11/24 15:30:18, Daniel Erat wrote:
> Remove this?  Some of these are packages that you installed locally but that
> aren't actually required in the repo, right?
> 
> (Disclaimer: I am a vi user.)

http://codereview.chromium.org/434033/diff/1001/1004#newcode248
src/package_repo/repo_list_dev.txt:248: libgtk2.0-0 2.17.7-0ubuntu3 optional
libs pool/main/g/gtk+2.0/libgtk2.0-0_2.17.7-0ubuntu3_i386.deb
cc'ed sky.

Can I have the bug id of the drawing issue? I'll check whether the bug
reproduces with 2.17.7 or not. btw, 2.17.7 is the minimum Gtk version which IBus
requires.

On 2009/11/24 15:30:18, Daniel Erat wrote:
> You might want to check with sky@ about this -- he was suspecting that the old
> version might've been responsible for the white-boxes-in-the-tab-strip drawing
> bug that we've been seeing.  He and I both had trouble when we tried 2.18, but
> it's possible that this version works and fixes the bug.

http://codereview.chromium.org/434033/diff/1001/1004#newcode558
src/package_repo/repo_list_dev.txt:558: update-inetd 4.31 optional admin
pool/main/u/update-inetd/update-inetd_4.31_all.deb
The same as emacsen-common. cmake-data requires this.

On 2009/11/24 15:30:18, Daniel Erat wrote:
> Where did this come from?

[Randall Spangler, 2009-11-24 17:28:51]

http://codereview.chromium.org/434033/diff/1001/1008
File src/third_party/ibus-anthy/make_pkg.sh (right):

http://codereview.chromium.org/434033/diff/1001/1008#newcode30
src/third_party/ibus-anthy/make_pkg.sh:30: # apply patches
Doesn't this leave the patches on top of the source files at the end of the
build?  That can cause problems if the underlying source is updated; it won't
update files which are locally modified.

Better to copy the source files into ~/src/build/ibus-anthy/ (or similar) before
patching.

Alternately, unpatch after the build.

http://codereview.chromium.org/434033/diff/1001/1010
File src/third_party/ibus-chewing/make_pkg.sh (right):

http://codereview.chromium.org/434033/diff/1001/1010#newcode31
src/third_party/ibus-chewing/make_pkg.sh:31: rm -fr
"${TOP_SCRIPT_DIR}/files/debian"
(same issue here - need to copy source before patching, or unpatch after build)

[Yusuke Sato, 2009-11-25 03:06:41]

Thanks, fixed the scripts.

http://codereview.chromium.org/434033/diff/1001/1008
File src/third_party/ibus-anthy/make_pkg.sh (right):

http://codereview.chromium.org/434033/diff/1001/1008#newcode30
src/third_party/ibus-anthy/make_pkg.sh:30: # apply patches
On 2009/11/24 17:28:51, Randall Spangler wrote:
> Doesn't this leave the patches on top of the source files at the end of the
> build?  That can cause problems if the underlying source is updated; it won't
> update files which are locally modified.
> 
> Better to copy the source files into ~/src/build/ibus-anthy/ (or similar)
before
> patching.
> 
> Alternately, unpatch after the build.

Modified the script so it copies the tree to src/build/ibus-chewing/build/
before patching, just like src/third_party/xserver-xorg-core/make_pkg.sh does.

http://codereview.chromium.org/434033/diff/1001/1010
File src/third_party/ibus-chewing/make_pkg.sh (right):

http://codereview.chromium.org/434033/diff/1001/1010#newcode31
src/third_party/ibus-chewing/make_pkg.sh:31: rm -fr
"${TOP_SCRIPT_DIR}/files/debian"
On 2009/11/24 17:28:51, Randall Spangler wrote:
> (same issue here - need to copy source before patching, or unpatch after
build)

The same as above. Fixed.

[Randall Spangler, 2009-11-25 16:58:41]

lgtm for make_pkg changes
(will defer to Dan on the rest of the review)

[Daniel Erat, 2009-11-25 17:12:49]

LGTM

[Yusuke Sato, 2009-11-27 02:17:50]

On 2009/11/25 17:12:49, Daniel Erat wrote:
> LGTM

Landed in r325. Thanks.