net/socket/ssl_client_socket_unittest.cc - Issue 4339001: Correctly handle SSL Client Authentication requests when connecting...

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 4339001: Correctly handle SSL Client Authentication requests when connecting... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Rebase... Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_unittest.cc

===================================================================

--- net/socket/ssl_client_socket_unittest.cc (revision 65819)

+++ net/socket/ssl_client_socket_unittest.cc (working copy)

@@ -67,7 +67,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -105,7 +106,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -145,7 +147,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -189,7 +192,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -232,7 +236,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), ssl_config,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), ssl_config,

NULL));

EXPECT_FALSE(sock->IsConnected());

@@ -275,7 +280,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

rv = sock->Connect(&callback);

@@ -331,7 +337,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

rv = sock->Connect(&callback);

@@ -386,7 +393,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

rv = sock->Connect(&callback);

@@ -437,7 +445,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

rv = sock->Connect(&callback);

@@ -508,7 +517,8 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

- transport, test_server.host_port_pair().host(), kDefaultSSLConfig,

+ transport, test_server.host_port_pair().host(),

+ test_server.host_port_pair().port(), kDefaultSSLConfig,

NULL));

rv = sock->Connect(&callback);

@@ -559,7 +569,7 @@

scoped_ptr<net::SSLClientSocket> sock(

socket_factory_->CreateSSLClientSocket(

transport, test_server.host_port_pair().host(),

- ssl_config, NULL));

+ test_server.host_port_pair().port(), ssl_config, NULL));

EXPECT_FALSE(sock->IsConnected());

« net/socket/client_socket_factory.h ('K') | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »