Correctly handle SSL Client Authentication requests when connecting...

net/socket/client_socket_factory.h

Index: net/socket/client_socket_factory.h
===================================================================
--- net/socket/client_socket_factory.h	(revision 65819)
+++ net/socket/client_socket_factory.h	(working copy)
@@ -8,6 +8,7 @@
 
 #include <string>
 
+#include "base/basictypes.h"
 #include "net/base/net_log.h"
 
 namespace net {
@@ -24,6 +25,7 @@
 typedef SSLClientSocket* (*SSLClientSocketFactory)(
     ClientSocketHandle* transport_socket,
     const std::string& hostname,
+    uint16 port,
     const SSLConfig& ssl_config,
     SSLHostInfo* ssl_host_info,
     DnsRRResolver* dnsrr_resolver);
@@ -44,6 +46,7 @@
   virtual SSLClientSocket* CreateSSLClientSocket(
       ClientSocketHandle* transport_socket,
       const std::string& hostname,
+      uint16 port,

[eroman, 2010/11/11 19:18:31]

Please change the function signature to take a |const HostPortPair&| instead.

The advantage of HostPortPair is it is more expressive, and allows us to do
assertions more uniformly. With naked "hostname" parameters we have run into
problems needing to explain at every single callsite what sort of data it
contains. i.e. does it include square brackets around IPv6 literals? Is it
already canonicalized? etc... By passing around a HostPortPair instead we can
enforce and document those expectations more uniformly in one chokepoint. And
assert at construction time that it is good.

       const SSLConfig& ssl_config,
       SSLHostInfo* ssl_host_info,
       DnsRRResolver* dnsrr_resolver) = 0;
@@ -51,6 +54,7 @@
   // Deprecated function (http://crbug.com/37810) that takes a ClientSocket.
   virtual SSLClientSocket* CreateSSLClientSocket(ClientSocket* transport_socket,
                                                  const std::string& hostname,
+                                                 uint16 port,
                                                  const SSLConfig& ssl_config,
                                                  SSLHostInfo* ssl_host_info);