Issue 4321007: Verify that we don't receive a NULL pointer for the session_id. This check wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4321007: Verify that we don't receive a NULL pointer for the session_id. This check wi... (Closed)

Created:
10 years, 1 month ago by hansl_g

Modified:
9 years, 7 months ago

Reviewers:
MAD, hansl

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Verify that we don't receive a NULL pointer for the session_id. This check will be removed as soon as getSessionId is implemented in ChromeFrame. Also, it is not needed for the other code path as ChromeFrame does make the check in it. BUG=3161153 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64947

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	ceee/ie/common/chrome_frame_host.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

MAD

LGTM... So I guess the test is there on the Chrome Frame side, right? BYE ...

10 years, 1 month ago (2010-11-03 18:10:55 UTC) #2

hansl

10 years, 1 month ago (2010-11-03 18:12:05 UTC) #3

Yes it will.

On 2010/11/03 18:10:55, mad1 wrote:
> LGTM...
> 
> So I guess the test is there on the Chrome Frame side, right?
> 
> BYE
> MAD

Expand Messages | Collapse Messages