Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: ceee/ie/common/chrome_frame_host.cc

Issue 4321007: Verify that we don't receive a NULL pointer for the session_id. This check wi... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ceee/ie/common/chrome_frame_host.cc
===================================================================
--- ceee/ie/common/chrome_frame_host.cc (revision 64914)
+++ ceee/ie/common/chrome_frame_host.cc (working copy)
@@ -171,8 +171,12 @@
if (chrome_frame_internal_) {
return chrome_frame_internal_->getSessionId(session_id);
} else {
- *session_id = kInvalidChromeSessionId;
- return S_OK;
+ // This whole else should be removed when getSessionId gets committed to
+ // ChromeFrame.
+ if (session_id != NULL) {
+ *session_id = kInvalidChromeSessionId;
+ return S_OK;
+ }
}
}
NOTREACHED();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698