Issue 432001: Remove the deprecated version of ContentsEqual....

Issue 432001: Remove the deprecated version of ContentsEqual.... (Closed)

Created:
11 years, 1 month ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Nico, Evan Martin

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Remove the deprecated version of ContentsEqual. BUG=24672 TEST=base_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33483

Patch Set 1 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -9 lines)			Patch
M	base/file_util.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	base/file_util.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/file_util_unittest.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

On 2009/11/24 02:33:14, tfarina wrote: > Evan, could you take a look? Sent this to ...

11 years ago (2009-12-01 16:58:07 UTC) #2

Evan Martin

On 2009/12/01 16:58:07, Nico wrote: > On 2009/11/24 02:33:14, tfarina wrote: > > Evan, could ...

11 years ago (2009-12-01 20:32:47 UTC) #3

tfarina (gmail-do not use)

On 2009/12/01 16:58:07, Nico wrote: > On 2009/11/24 02:33:14, tfarina wrote: > > Evan, could ...

11 years ago (2009-12-01 21:43:04 UTC) #4

Nico

11 years ago (2009-12-01 22:14:02 UTC) #5

LG I guess. I'll land.

Thanks for the patch.

On Tue, Dec 1, 2009 at 1:43 PM,  <thiago.farina@gmail.com> wrote:
> On 2009/12/01 16:58:07, Nico wrote:
>>
>> On 2009/11/24 02:33:14, tfarina wrote:
>> > Evan, could you take a look?
>
>> Sent this to the try servers. Looks like Rietveld missed it, though. But
>> it's
>> there.
>
> Nico, Evan, I'm attaching the trybot results here:
> http://build.chromium.org/buildbot/try-server/builders/linux/builds/10093
> http://build.chromium.org/buildbot/try-server/builders/mac/builds/10160
> http://build.chromium.org/buildbot/try-server/builders/win/builds/10556
>
> http://codereview.chromium.org/432001
>

Expand Messages | Collapse Messages