Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 43148: Remove unneeded uses of logging.h in header files. (Closed)

Created:
11 years, 9 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
wtc, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove unneeded uses of logging.h in header files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11590

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M base/condition_variable.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/non_thread_safe.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/non_thread_safe.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/task.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/test_file_util_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/timer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/watchdog.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/worker_pool_linux.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/worker_pool_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_thread.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_exe.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/icon_loader.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/dns_host_info.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/url_fetcher_protect.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/url_fetcher_protect.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_info.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_host_state.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/views/hung_renderer_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/keyword_editor_view.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/window_sizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/window_sizer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_plugin_util.h View 1 1 chunk +2 lines, -0 lines 2 comments Download
M chrome/test/testing_browser_process.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/base/file_stream.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/base/listen_socket_unittest.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/disk_cache/mapped_file_posix.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/mapped_file_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/mem_backend_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/mem_entry_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_cache.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/src/sandbox_policy_base.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/src/sandbox_policy_base.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/memory_watcher/hotkey.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/memory_watcher/memory_watcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/default_plugin/plugin_impl_mac.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/default_plugin/plugin_impl_win.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/cpp_bound_class.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/cpp_bound_class.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/glue_accessibility.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/inspector_client_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
11 years, 9 months ago (2009-03-12 18:56:30 UTC) #1
wtc
Your changes to the files under net and chrome/browser/ssl look good to me.
11 years, 9 months ago (2009-03-12 20:14:21 UTC) #2
Evan Stade
11 years, 9 months ago (2009-03-12 22:28:30 UTC) #3 
As long as you are cleaning stuff up, it would be swell to clean up deprecated
styles.

other than that, rubbery LGTM

http://codereview.chromium.org/43148/diff/1043/2024
File chrome/common/chrome_plugin_util.h (right):

http://codereview.chromium.org/43148/diff/1043/2024#newcode6
Line 6: #define CHROME_COMMON_CHROME_PLUGIN_UTIL_H__
single trailing underscore.

http://codereview.chromium.org/43148/diff/1043/2024#newcode56
Line 56: DISALLOW_EVIL_CONSTRUCTORS(PluginHelper);
DISALLOW_COPY_AND_ASSIGN

Powered by Google App Engine
This is Rietveld 408576698