Issue 43087: Have scons fully evaluate order-only prequisites Nodes before evaluating...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43087: Have scons fully evaluate order-only prequisites Nodes before evaluating... (Closed)

Created:
11 years, 9 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Have scons fully evaluate order-only prequisites Nodes before evaluating a target direct sources and dependencies, so that the actions of the prerequisites can affect how the sources and dependencies get built (e.g. building ancillary files for use as input to other steps, without having to track the direct file dependency). This tracks an upstream SCons change that will appear in next release: http://scons.tigris.org/issues/show_bug.cgi?id=2372 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11461

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	third_party/scons/scons-local/SCons/Taskmaster.py	View	1	1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Comment change only, otherwise LGTM. http://codereview.chromium.org/43087/diff/1/2 File third_party/scons/scons-local/SCons/Taskmaster.py (right): http://codereview.chromium.org/43087/diff/1/2#newcode794 Line 794: # (sources and ...

11 years, 9 months ago (2009-03-11 18:42:57 UTC) #2

sgk

11 years, 9 months ago (2009-03-11 18:46:36 UTC) #3

http://codereview.chromium.org/43087/diff/1/2
File third_party/scons/scons-local/SCons/Taskmaster.py (right):

http://codereview.chromium.org/43087/diff/1/2#newcode794
Line 794: # (sources and dependencies) are evaluated.  This is an advance
On 2009/03/11 18:42:58, Mark Mentovai wrote:
> in advance

Done.

Submitting, NRN.

Expand Messages | Collapse Messages