Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/scons/scons-local/SCons/Taskmaster.py

Issue 43087: Have scons fully evaluate order-only prequisites Nodes before evaluating... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/scons/scons-local/SCons/Taskmaster.py
===================================================================
--- third_party/scons/scons-local/SCons/Taskmaster.py (revision 11450)
+++ third_party/scons/scons-local/SCons/Taskmaster.py (working copy)
@@ -789,7 +789,17 @@
children_not_ready = []
children_failed = False
- for child in chain(children, executor.get_all_prerequisites()):
+ #TODO(sgk)
+ # Evaluate order-only prerequisites before any "direct" children
+ # (sources and dependencies) are evaluated. This is in advance
+ # of a change that will be incorporated in the next upstream
+ # version of SCons, per:
+ # http://scons.tigris.org/issues/show_bug.cgi?id=2372
+ #TODO(sgk) - FROM THIS:
+ #for child in chain(children, executor.get_all_prerequisites()):
+ #TODO(sgk) - TO THIS:
+ for child in chain(executor.get_all_prerequisites(), children):
+ #TODO(sgk) - END CHANGES.
childstate = child.get_state()
if T: T.write(self.trace_message(' ' + self.trace_node(child)))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698