Stack checks in generated code for function apply is now controlled...

Stack checks in generated code for function apply is now controlled
by the check-stack flag. Changed the condition code from greater to
above_equal as the SP should be unsigned (this matches the stack
check in function entry).

Committed: http://code.google.com/p/v8/source/detail?r=384

[bak, 2008-09-26 09:25:50]

LGTM,
  Lars

http://codereview.chromium.org/4296/diff/1/2
File src/builtins-ia32.cc (right):

http://codereview.chromium.org/4296/diff/1/2#newcode520
Line 520: if (true && FLAG_check_stack) {
Please remove true &&. It does not add much.

[Søren Thygesen Gjesse, 2008-09-26 10:33:15]

Removed the change from greater to above_equal. It did not work, as the
calculation of the expected SP can wrap around 0. Erik Corry has CL
http://codereview.chromium.org/2926 open for fixing this issue more generally.

http://codereview.chromium.org/4296/diff/1/2
File src/builtins-ia32.cc (right):

http://codereview.chromium.org/4296/diff/1/2#newcode520
Line 520: if (true && FLAG_check_stack) {
On 2008/09/26 09:25:50, bak wrote:
> Please remove true &&. It does not add much.

Sorry about that - testing leftover.