Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2926: Fix stack check wraparound problem for ARM simulator. (Closed)

Created:
12 years, 3 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix stack check wraparound problem for ARM simulator. Committed: http://code.google.com/p/v8/source/detail?r=385

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M src/builtins-ia32.cc View 1 1 chunk +31 lines, -5 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Erik Corry
12 years, 3 months ago (2008-09-17 11:44:34 UTC) #1
iposva
Recording off-line discussion... -ip http://codereview.chromium.org/2926/diff/1/2 File src/builtins-ia32.cc (right): http://codereview.chromium.org/2926/diff/1/2#newcode532 Line 532: __ j(greater, &okay, taken); ...
12 years, 3 months ago (2008-09-17 13:18:02 UTC) #2
Erik Corry
12 years, 3 months ago (2008-09-22 09:57:43 UTC) #3
Søren Thygesen Gjesse
12 years, 3 months ago (2008-09-26 10:55:19 UTC) #4
LGTM

http://codereview.chromium.org/2926/diff/4/204
File src/builtins-ia32.cc (right):

http://codereview.chromium.org/2926/diff/4/204#newcode527
Line 527: __ j(above, &no_preemption, taken);
void Ia32CodeGenerator::CheckStack() uses above_equal.

Powered by Google App Engine
This is Rietveld 408576698