Issue 4287001: Integrating CEEE into top-level .gyp files so that it builds....

Issue 4287001: Integrating CEEE into top-level .gyp files so that it builds.... (Closed)

Created:
10 years, 1 month ago by Jói

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Integrating CEEE into top-level .gyp files so that it builds. TEST=it compiles, 'ceee' root folder is seen in Visual Studio projects tree BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64735

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -1 line)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_installer.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

amit

lgtm, go Joi! On Mon, Nov 1, 2010 at 7:09 PM, <joi@chromium.org> wrote: > Reviewers: ...

10 years, 1 month ago (2010-11-02 02:11:48 UTC) #2

lgtm, go Joi!


On Mon, Nov 1, 2010 at 7:09 PM, <joi@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Integrating CEEE into top-level .gyp files so that it builds.
>
> TEST=none
> BUG=none
>
>
>
> Please review this at http://codereview.chromium.org/4287001/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     build/all.gyp
>  M     chrome/chrome.gyp
>  M     chrome/chrome_installer.gypi
>
>
> Index: build/all.gyp
> ===================================================================
> --- build/all.gyp       (revision 64596)
> +++ build/all.gyp       (working copy)
> @@ -102,6 +102,7 @@
>           'dependencies': [
>             '../breakpad/breakpad.gyp:*',
>             '../chrome/app/locales/locales.gyp:*',
> +            '../ceee/ceee.gyp:*',
>             '../chrome_frame/chrome_frame.gyp:*',
>             '../courgette/courgette.gyp:*',
>             '../gears/gears.gyp:*',
> Index: chrome/chrome.gyp
> ===================================================================
> --- chrome/chrome.gyp   (revision 64596)
> +++ chrome/chrome.gyp   (working copy)
> @@ -1189,7 +1189,7 @@
>                   '-lgcrypt',
>                 ],
>               },
> -            }],
> +            }],
>           ],
>         }],
>         ['remoting==1', {
> @@ -1615,6 +1615,7 @@
>             'installer/mini_installer.gyp:*',
>             '../app/app.gyp:*',
>             '../base/base.gyp:*',
> +            '../ceee/ceee.gyp:*',
>             '../chrome_frame/chrome_frame.gyp:*',
>             '../gfx/gfx.gyp:*',
>             '../ipc/ipc.gyp:*',
> Index: chrome/chrome_installer.gypi
> ===================================================================
> --- chrome/chrome_installer.gypi        (revision 64596)
> +++ chrome/chrome_installer.gypi        (working copy)
> @@ -180,6 +180,9 @@
>             '<(DEPTH)/build/util/build_util.gyp:lastchange',
>             '<(DEPTH)/build/util/support/support.gyp:*',
>             '<(DEPTH)/build/win/system.gyp:cygwin',
> +            '<(DEPTH)/ceee/ie/broker/broker.gyp:ceee_broker',
> +            '<(DEPTH)/ceee/ie/plugin/toolband/toolband.gyp:ceee_ie',
> +
>  '<(DEPTH)/ceee/installer_dll/ceee_installer_dll.gyp:ceee_installer_helper',
>             '<(DEPTH)/chrome_frame/chrome_frame.gyp:npchrome_frame',
>           ],
>           'include_dirs': [
>
>
>

Jói

10 years, 1 month ago (2010-11-02 02:16:47 UTC) #3

Thanks for all the reviews Amit, this change's prereqs are now in so I
can run it on the trybots to see how it goes.


On Mon, Nov 1, 2010 at 10:11 PM, Amit Joshi <amit@chromium.org> wrote:
> lgtm, go Joi!
>
> On Mon, Nov 1, 2010 at 7:09 PM, <joi@chromium.org> wrote:
>>
>> Reviewers: amit,
>>
>> Description:
>> Integrating CEEE into top-level .gyp files so that it builds.
>>
>> TEST=none
>> BUG=none
>>
>>
>>
>> Please review this at http://codereview.chromium.org/4287001/show
>>
>> SVN Base: svn://chrome-svn/chrome/trunk/src/
>>
>> Affected files:
>>  M     build/all.gyp
>>  M     chrome/chrome.gyp
>>  M     chrome/chrome_installer.gypi
>>
>>
>> Index: build/all.gyp
>> ===================================================================
>> --- build/all.gyp       (revision 64596)
>> +++ build/all.gyp       (working copy)
>> @@ -102,6 +102,7 @@
>>           'dependencies': [
>>             '../breakpad/breakpad.gyp:*',
>>             '../chrome/app/locales/locales.gyp:*',
>> +            '../ceee/ceee.gyp:*',
>>             '../chrome_frame/chrome_frame.gyp:*',
>>             '../courgette/courgette.gyp:*',
>>             '../gears/gears.gyp:*',
>> Index: chrome/chrome.gyp
>> ===================================================================
>> --- chrome/chrome.gyp   (revision 64596)
>> +++ chrome/chrome.gyp   (working copy)
>> @@ -1189,7 +1189,7 @@
>>                   '-lgcrypt',
>>                 ],
>>               },
>> -            }],
>> +            }],
>>           ],
>>         }],
>>         ['remoting==1', {
>> @@ -1615,6 +1615,7 @@
>>             'installer/mini_installer.gyp:*',
>>             '../app/app.gyp:*',
>>             '../base/base.gyp:*',
>> +            '../ceee/ceee.gyp:*',
>>             '../chrome_frame/chrome_frame.gyp:*',
>>             '../gfx/gfx.gyp:*',
>>             '../ipc/ipc.gyp:*',
>> Index: chrome/chrome_installer.gypi
>> ===================================================================
>> --- chrome/chrome_installer.gypi        (revision 64596)
>> +++ chrome/chrome_installer.gypi        (working copy)
>> @@ -180,6 +180,9 @@
>>             '<(DEPTH)/build/util/build_util.gyp:lastchange',
>>             '<(DEPTH)/build/util/support/support.gyp:*',
>>             '<(DEPTH)/build/win/system.gyp:cygwin',
>> +            '<(DEPTH)/ceee/ie/broker/broker.gyp:ceee_broker',
>> +            '<(DEPTH)/ceee/ie/plugin/toolband/toolband.gyp:ceee_ie',
>> +
>>  '<(DEPTH)/ceee/installer_dll/ceee_installer_dll.gyp:ceee_installer_helper',
>>             '<(DEPTH)/chrome_frame/chrome_frame.gyp:npchrome_frame',
>>           ],
>>           'include_dirs': [
>>
>>
>
>

Expand Messages | Collapse Messages