Add a system() call to the d8 shell (Unix only).

Add a system() call to the d8 shell (Unix only).

Committed: http://code.google.com/p/v8/source/detail?r=1633

[Mads Ager (chromium), 2009-03-26 13:39:47]

LGTM

We should make sure to implement this on Windows so d8 works equally well on all
supported platforms.

http://codereview.chromium.org/42641/diff/1/5
File src/d8-posix.cc (right):

http://codereview.chromium.org/42641/diff/1/5#newcode147
Line 147: if (seconds * 1000000 + time_now.tv_usec - start_time->tv_usec >
total_time * 1000) {
Does it lint?

How about naming some intermediate results?

http://codereview.chromium.org/42641/diff/1/5#newcode202
Line 202: Handle<Value> Shell::System(const Arguments& args) {
This method is very, very big.  There seems to be phases here that you should be
able to factor out?

http://codereview.chromium.org/42641/diff/1/5#newcode208
Line 208: if (args.Length() > first_argument && args[first_argument]->IsInt32())
{
I would like to have the optional timeout arguments after the program and
arguments.  How about requiring a string name, an array of arguments, and then
having two optional timeouts after that:

system("program", [1, 2, 3, 4], 100, 100)?

http://codereview.chromium.org/42641/diff/1/5#newcode289
Line 289: if (WaitOnFD(stdout_fds[kReadFD], read_timeout, total_timeout,
&start_time) ||
Long line.

http://codereview.chromium.org/42641/diff/1/3
File src/d8-windows.cc (right):

http://codereview.chromium.org/42641/diff/1/3#newcode39
Line 39: return ThrowException(String::New("system() is not yet supported on
your OS"));
Long line.

[Mads Ager (chromium), 2009-03-27 11:45:21]

LGTM

http://codereview.chromium.org/42641/diff/3001/3005
File src/d8-posix.cc (right):

http://codereview.chromium.org/42641/diff/3001/3005#newcode477
Line 477: if (!WaitForChild(pid, child_waiter, start_time, read_timeout,
total_timeout)) {
This line looks too long.

http://codereview.chromium.org/42641/diff/3001/3003
File src/d8-windows.cc (right):

http://codereview.chromium.org/42641/diff/3001/3003#newcode40
Line 40: ThrowException(String::New("system() is not yet supported on your
OS"));
Nit picking, but I don't like this indentation.  How about:

Handle<String> error_message =
    String::New("system() is not yet supported on your OS");
return ThrowException(error_message);

[workitharder_gmail.com, 2010-12-20 20:31:49]

Did this ever make it into trunk?

I'm quite interested in the possibility of using V8 for systems programming, due
to the great performance displayed at 
http://shootout.alioth.debian.org/u32/javascript.php