Issue 42626: Report the plugin position to windowed plugins as (0,0)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42626: Report the plugin position to windowed plugins as (0,0)... (Closed)

Created:
11 years, 9 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Report the plugin position to windowed plugins as (0,0) . the NPAPI documentation says it should be reported relative to the parent HWND, which is the plugin's coordinates on the page. This assumption breaks in Chrome because we have an intermediate HWND. I've tested on a bunch of pages to see if this change causes regressions, if we find any in the future we can reconsider this. BUG=6742 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12587

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -41 lines)			Patch
M	chrome/plugin/webplugin_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/plugin/webplugin_proxy.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/test/plugin_window_size_test.cc	View		2 chunks	+14 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl.cc	View	1	5 chunks	+14 lines, -18 lines	0 comments	Download
M	webkit/glue/webplugin.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	webkit/glue/webplugin_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webplugin_impl.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_win.cc	View		1 chunk	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for the unit test

Expand Messages | Collapse Messages