Report the plugin position to windowed plugins as (0,0)...

webkit/glue/plugins/webplugin_delegate_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/plugins/webplugin_delegate_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_util.h"
@@ skipping 127 matching lines @@
 WebPluginDelegateImpl::WebPluginDelegateImpl(
     gfx::NativeView containing_view,
     NPAPI::PluginInstance *instance)
     : parent_(containing_view),
       instance_(instance),
       quirks_(0),
       plugin_(NULL),
       windowless_(false),
       windowed_handle_(NULL),
       windowed_did_set_window_(false),
+      windowed_manage_position_(false),
       windowless_needs_set_window_(true),
       plugin_wnd_proc_(NULL),
       last_message_(0),
       is_calling_wndproc(false),
       dummy_window_for_activation_(NULL),
       handle_event_message_filter_hook_(NULL),
       handle_event_pump_messages_event_(NULL),
       handle_event_depth_(0),
       user_gesture_message_posted_(false),
 #pragma warning(suppress: 4355)  // can use this
@@ skipping 101 matching lines @@
     // the window handle and validate the same. The window handle can be
     // retreived via NPN_GetValue of NPNVnetscapeWindow.
     instance_->set_window_handle(parent_);
     CreateDummyWindowForActivation();
     handle_event_pump_messages_event_ = CreateEvent(NULL, TRUE, FALSE, NULL);
   } else {
     if (!WindowedCreatePlugin())
       return false;
   }
 
-  plugin->SetWindow(windowed_handle_, handle_event_pump_messages_event_);
+  windowed_manage_position_ =
+      plugin->SetWindow(windowed_handle_, handle_event_pump_messages_event_);
   plugin_url_ = url.spec();
 
   // The windowless version of the Silverlight plugin calls the
   // WindowFromPoint API and passes the result of that to the
   // TrackPopupMenu API call as the owner window. This causes the API
   // to fail as the API expects the window handle to live on the same
   // thread as the caller. It works in the other browsers as the plugin
   // lives on the browser thread. Our workaround is to intercept the
   // TrackPopupMenu API for Silverlight and replace the window handle
   // with the dummy activation window.
@@ skipping 263 matching lines @@
   // all active plugins with each pass through the throttle, otherwise
   // we see video jankiness.
   std::list<MSG>* throttle_queue = g_throttle_queue.Pointer();
   std::map<HWND, int> processed;
 
   std::list<MSG>::iterator it = throttle_queue->begin();
   while (it != throttle_queue->end()) {
     const MSG& msg = *it;
     if (processed.find(msg.hwnd) == processed.end()) {
       WNDPROC proc = reinterpret_cast<WNDPROC>(msg.time);
-          // It is possible that the window was closed after we queued
-          // this message.  This is a rare event; just verify the window
-          // is alive.  (see also bug 1259488)
-          if (IsWindow(msg.hwnd))
+      // It is possible that the window was closed after we queued
+      // this message.  This is a rare event; just verify the window
+      // is alive.  (see also bug 1259488)
+      if (IsWindow(msg.hwnd))
           CallWindowProc(proc, msg.hwnd, msg.message, msg.wParam, msg.lParam);
       processed[msg.hwnd] = 1;
       it = throttle_queue->erase(it);
     } else {
       it++;
     }
   }
 
   if (throttle_queue->size() > 0)
     MessageLoop::current()->PostDelayedTask(FROM_HERE,
@@ skipping 121 matching lines @@
     const gfx::Rect& window_rect,
     const gfx::Rect& clip_rect) {
   if (!windowed_handle_) {
     NOTREACHED();
     return false;
   }
 
   if (window_rect_ == window_rect && clip_rect_ == clip_rect)
     return false;
 
-  // There are a few parts to managing the plugin windows:
-  //   - Initial geometry, show / resize / position the window.
-  //   - Geometry updates, resize the window.
-  //   - Geometry updates, move the window or update the clipping region.
-  // This code should handle the first two, positioning and sizing the window
-  // initially, and resizing it when the size changes.  Clipping and moving are
-  // handled separately by WebPlugin, after it has called this code.  This
-  // allows window moves, like scrolling, to be synchronized with painting.
-  // See WebPluginImpl::setFrameRect().
+  // If windowed_manage_position_ is false, then the plugin will be moved
+  // elsewhere.  This allows the window moves/scrolling/clipping to be
+  // synchronized with the page and other windows.
   if (window_rect.size() != window_rect_.size()) {
     ::SetWindowPos(windowed_handle_,
                    NULL,
-                   0,
-                   0,
+                   windowed_manage_position_ ? window_rect.x() : 0,
+                   windowed_manage_position_ ? window_rect.y() : 0,
                    window_rect.width(),
                    window_rect.height(),
                    SWP_SHOWWINDOW);
   }
 
   window_rect_ = window_rect;
   clip_rect_ = clip_rect;
 
   // Ensure that the entire window gets repainted.
   ::InvalidateRect(windowed_handle_, NULL, FALSE);
@@ skipping 13 matching lines @@
   instance()->set_window_handle(windowed_handle_);
 
   DCHECK(!instance()->windowless());
 
   window_.clipRect.top = clip_rect_.y();
   window_.clipRect.left = clip_rect_.x();
   window_.clipRect.bottom = clip_rect_.y() + clip_rect_.height();
   window_.clipRect.right = clip_rect_.x() + clip_rect_.width();
   window_.height = window_rect_.height();
   window_.width = window_rect_.width();
-  window_.x = window_rect_.x();
-  window_.y = window_rect_.y();
+  window_.x = windowed_manage_position_ ? window_rect_.x() : 0;
+  window_.y = windowed_manage_position_ ? window_rect_.y() : 0;
 
   window_.window = windowed_handle_;
   window_.type = NPWindowTypeWindow;
 
   // Reset this flag before entering the instance in case of side-effects.
   windowed_did_set_window_ = true;
 
   NPError err = instance()->NPP_SetWindow(&window_);
   if (quirks_ & PLUGIN_QUIRK_SETWINDOW_TWICE)
     instance()->NPP_SetWindow(&window_);
@@ skipping 435 matching lines @@
 
   // It is ok to pass NULL here to GetCursor as we are not looking for cursor
   // types defined by Webkit.
   HCURSOR previous_cursor =
       g_current_plugin_instance->current_windowless_cursor_.GetCursor(NULL);
 
   g_current_plugin_instance->current_windowless_cursor_.InitFromExternalCursor(
       cursor);
   return previous_cursor;
 }