Issue 42623: Make the bookmarks bar disappear when the load after the new tab page commits...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42623: Make the bookmarks bar disappear when the load after the new tab page commits... (Closed)

Created:
11 years, 9 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the bookmarks bar disappear when the load after the new tab page commits rather than when it is pending. This makes it change at the same time the page changes. To support this, we now have to keep track of both a pending and a committed DOMUI object. This is tracked by the RenderManager, which does a similar swapping between pending and committed RenderViewHosts. Previous review URL: http://codereview.chromium.org/42512 The only difference is I swapped the order of creating the DOM UI in RenderViewHostManager::Navigate. BUG=8963 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12515

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -80 lines)			Patch
M	chrome/browser/dom_ui/new_tab_ui.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1	2 chunks	+24 lines, -14 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager.h	View		5 chunks	+37 lines, -13 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager.cc	View		14 chunks	+44 lines, -23 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.h	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.cc	View		12 chunks	+64 lines, -25 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/unit/unittests.vcproj	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages