Make the bookmarks bar disappear when the load after the new tab page commits...

Make the bookmarks bar disappear when the load after the new tab page commits
rather than when it is pending. This makes it change at the same time the
page changes.

To support this, we now have to keep track of both a pending and a committed
DOMUI object. This is tracked by the RenderManager, which does a similar
swapping between pending and committed RenderViewHosts.

BUG=8963
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12469

[jcampan, 2009-03-25 17:01:43]

LGTM

http://codereview.chromium.org/42512/diff/10/1019
File chrome/browser/dom_ui/dom_ui_unittest.cc (right):

http://codereview.chromium.org/42512/diff/10/1019#newcode19
Line 19: // WebContents when we first navigate do a DOM UI page, then to a
standard
nit: typo "navigate do a DOM UI page" -> "to a DOM UI page"

http://codereview.chromium.org/42512/diff/10/1019#newcode61
Line 61:
static_cast<TestRenderViewHost*>(contents()->render_manager()->pending_render_view_host())->SendNavigate(2,
next_url);
Line is more than 80 chars

http://codereview.chromium.org/42512/diff/10/1018
File chrome/browser/tab_contents/web_contents.cc (right):

http://codereview.chromium.org/42512/diff/10/1018#newcode1632
Line 1632: // enderView, that means it's for the pending entry, so we have to
use the
Nit: typo enderView -> RenderView